Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Error on EditRepositoryPage #640

Closed
gitblit opened this issue Aug 12, 2015 · 2 comments
Closed

Internal Error on EditRepositoryPage #640

gitblit opened this issue Aug 12, 2015 · 2 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 344

What steps will reproduce the problem?
1. Open the EditRepositoryPage by editing or creating a repository
2. Select the access permissions tab
3. Select a permission in the user or team permissions section
4. Click the add button

This (3) is also the state after adding a permission.

What is the expected output? What do you see instead?
The button should have no effect, like when no permission is selected.

What version of the product are you using? On what operating system?
Gitblit WAR 1.3.2
patch based on 1.4.0-SNAPSHOT, commit 3daba4304dba818d54eb9b74d8d35df5aab8fee5 (2013-11-22
16:36:05)
OS:
Debian Wheezy (3.2.0-4-amd64 #1 SMP Debian 3.2.51-1 x86_64 GNU/Linux)
Java:
java version "1.7.0_25"
OpenJDK Runtime Environment (IcedTea 2.3.10) (7u25-2.3.10-1~deb7u1)
OpenJDK 64-Bit Server VM (build 23.7-b01, mixed mode)

Please provide any additional information below.
I'm unsure if registrant == null (no user/team selected) is a valid choice anywhere
else, my patch assumes that it is never valid.

Reported by fpeters.fae on 2013-11-26 13:31:00


- _Attachment: [gitblit.patch](https://storage.googleapis.com/google-code-attachments/gitblit/issue-344/comment-0/gitblit.patch)_
@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Merged to master.  Thanks for the patch!

Reported by James.Moger on 2013-11-26 13:49:40

  • Status changed: Queued
  • Labels added: Milestone-1.4.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants