Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe in a User's name breaks Google Charts #646

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

Apostrophe in a User's name breaks Google Charts #646

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 350

What steps will reproduce the problem?
Have a repository that contains commits made by a user which has a name that contains
an apostrophe. 

Sorry I'm not sure if there are other steps required apart from the one above (E.g.
if that user needs to have a certain number of commits, etc.)

What is the expected output? What do you see instead?
Expected output - Google Charts for activity at the top of the "my dashboard" and "activity"
pages.
Actual output - Missing charts. The Chrome console shows an "Unexpected Identifier"
error on the line...
data_39b7080b.setValue(7, 0, 'John O'Doe');


What version of the product are you using? On what operating system?
1.3.2

Please provide any additional information below.
I'll create a fix for this issue and submit a PR.

Reported by alex.lewis001 on 2013-12-10 15:50:56

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I've submitted a PR - https://github.com/gitblit/gitblit/pull/128

Reported by alex.lewis001 on 2013-12-10 16:50:03

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-12-10 20:22:36

  • Status changed: Queued
  • Labels added: Milestone-1.4.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants