Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special chars in repo / folder names #658

Closed
gitblit opened this issue Aug 12, 2015 · 7 comments
Closed

Special chars in repo / folder names #658

gitblit opened this issue Aug 12, 2015 · 7 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 362

What steps will reproduce the problem?
1. create a repo named 'hähä'
2. try to clone

What is the expected output? What do you see instead?
On git-receive-pack you will git HTTP 404


What version of the product are you using? On what operating system?
1.3.2

Please provide any additional information below.

In com.gitblit.AuthenticationFilter.getFullUrl(HttpServletRequest) we need to unescape
the URL, see pull request.

Reported by matthias.cullmann on 2014-01-28 10:15:09

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I created a pull request under:
https://github.com/gitblit/gitblit/pull/136

Reported by matthias.cullmann on 2014-01-28 10:18:00

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Thanks for the patch.  Merged.

Reported by James.Moger on 2014-01-28 12:50:33

  • Status changed: Queued
  • Labels added: Milestone-1.4.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hi Matthias,

Your change that I merged in pr-136 is causing failures.  I retested the scenario reported
 here and I am able to clone just fine without the fix.  I am considering reverting
the change made in pr-136 since I don't see evidence that it improves things and in
fact, I have evidence that it breaks cloning.

Can you craft a new failure scenario or have a comment?

-J

Reported by James.Moger on 2014-06-10 21:23:56

  • Status changed: New

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Well, it might depend on the encoding settings on the OS / VM.
If you feel it is not an improvement, then of course you should revert.


Reported by matthias.cullmann on 2014-06-11 16:51:34

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

What were your client & server platforms when you came across this issue?

Reported by James.Moger on 2014-06-11 16:53:31

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I reverted pr-136 in 1.6.0.

Reported by James.Moger on 2014-06-17 00:25:42

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants