Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Redmine users are administrators in Gitblit #664

Closed
gitblit opened this issue Aug 12, 2015 · 5 comments
Closed

All Redmine users are administrators in Gitblit #664

gitblit opened this issue Aug 12, 2015 · 5 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 368

What steps will reproduce the problem?

1.I set Redmine Authentification like in: http://gitblit.com/setup_authentication.html
2.It works just fine, but every Redmine-user is a admin in Gitblit (see screenshots)

What is the expected output? What do you see instead?

Only users that are admins in Redmine should be admins in Gitblit.

What version of the product are you using? On what operating system?

    - GitBlit 1.3.2
    - Redmine 2.3.1
    - Ubuntu 13.10


Reported by fischer.johann89 on 2014-02-13 23:05:20


- _Attachment: users_in_redmine.PNG
![users_in_redmine.PNG](https://storage.googleapis.com/google-code-attachments/gitblit/issue-368/comment-0/users_in_redmine.PNG)_ - _Attachment: users_in_gitblit.PNG
![users_in_gitblit.PNG](https://storage.googleapis.com/google-code-attachments/gitblit/issue-368/comment-0/users_in_gitblit.PNG)_
@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Yeah,  I've never been happy with this.  Gitblit is relying on an undocumented behavior
of Redmine.  And it sounds like the behavior has changed.

https://dev.gitblit.com/blob/gitblit.git/master/src!main!java!com!gitblit!auth!RedmineAuthProvider.java#L137

Reported by James.Moger on 2014-02-14 13:48:09

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I pushed a fix to master to remove this behavior.

Reported by James.Moger on 2014-02-21 14:06:58

  • Status changed: Queued
  • Labels added: Milestone-1.4.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Thanks.
Now I can use it without workaround :-)

Reported by fischer.johann89 on 2014-02-21 14:31:50

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

You can if you are building from master.

Reported by James.Moger on 2014-02-21 14:41:22

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants