Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagesServlet cannot enter in more than one directoy level on file list view #707

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

Comments

@gitblit
Copy link
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 411

CONTEXT:
release: 1.5.0
Jetty/GO deployment

TESTCASE:
1. Create a gh-pages branches in a git repository
2. create/commit/push a directory tree like : mydir/mysubdir1/mysubdir2 and put some
files in mysubdir2
3. clic on pages, you see mydir1 in an simple file list
4. clic on it, you see mysubdir1, but the URL behind is wrong, if you clic on, page
is empty.

EXPECTED:
clicking on mysubdir1 must display a list with mysubdir2
clicking on mysubdir2 must display a list of mysubdir2 content

INDICATION:

URLS on directories must terminate by a trailing / on directory list pages to have
correct browser naviagtion.

PagesServlet must be modified to:
- add this triling slash on entries of directory type (TREE)
- do not make the list with "repository" variable but "res" variable which as not the
trailing slash comming from request.

=> very simple to fix.

Reported by olivier.rouits on 2014-04-23 14:50:39

@gitblit
Copy link
Owner Author

gitblit commented Aug 12, 2015

I pushed a fix to master which may resolve the issue.

Reported by James.Moger on 2014-04-23 15:20:03

  • Status changed: Queued
  • Labels added: Milestone-1.5.1

@gitblit
Copy link
Owner Author

gitblit commented Aug 12, 2015

Almost, but not quite.  New fix pending.

Reported by James.Moger on 2014-04-23 15:55:42

  • Status changed: Started

@gitblit
Copy link
Owner Author

gitblit commented Aug 12, 2015

Now working properly on master.

Reported by James.Moger on 2014-04-23 16:58:24

  • Status changed: Queued

@gitblit
Copy link
Owner Author

gitblit commented Aug 12, 2015

Fix or change deployed in 1.5.1 release.

Reported by James.Moger on 2014-05-07 17:48:03

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix modified the milestone: 1.5.1 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants