Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket notifications aren't sent to anyone when the ticket creator doesn't have the email address set #719

Closed
gitblit opened this issue Aug 12, 2015 · 10 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 423

The summary pretty much tells the story. If you open a ticket with a user that doesn't
have the email property set up, none of the watchers get any notification emails when
a new comment/commit appears. Not even those who has an email address set. I guess
this isn't intentional.

Reported by sundayfunday1234@outlook.com on 2014-05-09 18:03:59

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hmm.  Definitely not intentional.  Will investigate.

Reported by James.Moger on 2014-05-09 18:17:58

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Is this still an issue in 1.6.0?  I was never able to reproduce this scenario.

Reported by James.Moger on 2014-06-30 13:59:27

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Sure, I can still easily reproduce it anytime. I'm on 1.6.1-SNAPSHOT (8c0c9ae48f) at
the moment.

Previously I only tested it with LDAP users, but now I've tried with a local one -
same result. Just create a new user, leave the email address empty and that's it. In
both cases (i.e. LOCAL or LDAP creator), no watcher gets the email.

The instant I fill the creator's email address (even with a single "a" or something
which is obviously not a valid address) emails start to arrive.

(Also, issue #752 *might* be related but I doubt it.)

First I thought that maybe certain SMTP servers don't tolerate the way Gitblit sets
some headers based on the creator's credentials. For example:

From: test.local <gitblit@company.net>

which is the name of the creator's username combined with mail.fromAddress so it's
a bit bogus.

But anyway, I was wrong, I set mail.debug to true and still, no trace of any mailing
attempts at all as long as the mail attribute is empty. The moment I fill the mail
attrib and add a comment to an issue it appears in the logs:

2014-07-02 14:39:42 [INFO ] send: Re: [admin/test] test11 (#12)

So I'm pretty sure the cause is in the Gitblit code, not somewhere else.

Reported by sundayfunday1234@outlook.com on 2014-07-02 12:45:19

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hmm.  Ok, I'll get this resolved.
https://dev.gitblit.com/tickets/gitblit.git/132

Reported by James.Moger on 2014-07-04 15:41:52

  • Status changed: Accepted
  • Labels added: Milestone-1.6.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Cool! So could you reproduce it now?

Reported by sundayfunday1234@outlook.com on 2014-07-04 15:44:54

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Found it. Squished it. Merged fix.

Reported by James.Moger on 2014-09-08 17:16:48

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Awesome, thank you!

Reported by sundayfunday1234@outlook.com on 2014-09-08 17:17:54

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Sorry for the insanely long delay; took the summer off.  I'm shooting for a maintenance
release next week (it'll be a little more than just routine fixes).

Reported by James.Moger on 2014-09-08 17:21:18

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Yeah, I assumed it was that, I hope you had a good time :)

Can't wait for the release. Good to see you back, James!

Reported by sundayfunday1234@outlook.com on 2014-09-08 17:22:30

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

v1.6.1 released

Reported by James.Moger on 2014-10-20 21:36:02

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants