Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to "subscribe" to new tickets #721

Open
gitblit opened this issue Aug 12, 2015 · 13 comments
Open

Option to "subscribe" to new tickets #721

gitblit opened this issue Aug 12, 2015 · 13 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 425

This is my last issue for a while, I promise :)

So it's pretty important for reviewees to get notified of new tickets. ATM the only
automated way to notify one particular reviewee is to set her as responsible, but that's
not possible if:

- the ticket creator doesn't have RW access to the repo
- the repo has anonymous push enabled

In those cases the "responsible" dropdown is missing. Additionally, there might be
several people interested in new tickets while the responsible dropdown allows for
just one user.

Starring the repo or being the owner of it doesn't trigger notification emails for
new tickets either.

Would you please consider adding a way to "subscribe" to new tickets per repo, something
like this:

- Any number of reviewees subscribe to Repo X. A trivial means to do so is to extend
the starring feature to do this as well. (If I understand it correctly, all starring
currently does is that it makes those repos linked on "my dashboard".) Although this
wouldn't be as intuitive as having a separate button just for this - there can be several
ways of doing this, not sure which is the best.

- When a dev opens a new ticket in Repo X, all the subscribers get a notification of
the fact that a new issue has been created. They aren't automatically added to the
watchers of the ticket coz they'll want to individually decide if that particular ticket's
relevant to them or not. If it's not relevant they don't want to get all the additional
noise of comment/commit notifications.

- Those who are interested either add themselves to the watchers list or get responsible
and from then they get all the other notifications, too (commits, comments).

What do you think?

Reported by sundayfunday1234@outlook.com on 2014-05-09 18:48:26

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Agreed.  Gitblit needs repository watchers.

https://github.com/gitblit/gitblit/blob/master/src/main/java/com/gitblit/tickets/TicketNotifier.java#L574

As for anonymous pushes... you shouldn't be able to push anonymously to tickets.  That
is specifically prohibited.  I'll look into the responsible part.  I don't remember
it working that way - but I write alot of code so maybe.  :)

Reported by James.Moger on 2014-05-09 18:57:20

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Nah, I didn't mean that users can push to tickets anonymously. I meant that the "responsible"
dropdown is missing on the "new ticket" page when anonymous pushes (in general) are
enabled for the repo under access permissions. I don't see the exact reasoning behind
this, but that's the way it is currently.

Reported by sundayfunday1234@outlook.com on 2014-05-09 20:46:51

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

The responsible selection when anonymous push is enabled is a corner-case I didn't see.
 A hotfix has been pushed to master and develop.

Reported by James.Moger on 2014-05-12 12:52:21

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Thanks! Could you please explain the reason for the other case? I.e. when the ticket
creator has no RW access?

Reported by sundayfunday1234@outlook.com on 2014-05-12 12:58:02

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Sure:  Go to any github repo that you don't own & create an issue.  Same thing.

Reported by James.Moger on 2014-05-12 13:00:56

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Well, yeah, come to think of it, it makes sense. Those who are not allowed to push are
prolly not the ones to decide who's gonna merge it either. I was thinking a bit differently,
e.g. when code review is required (enforced) for a dev to get a commit into the repo,
but devs tend to have RW access when they are active contributors of a repo anyway.
Thanks!

Reported by sundayfunday1234@outlook.com on 2014-05-12 13:05:38

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

The code review "requirement" is loose.  You can still merge client-side and push that.
 The current purpose of tickets is not strict code review enforcement, it's light-weight
collaboration and communication.  I am sure it will evolve to be more sophisticated
in future releases.

Reported by James.Moger on 2014-05-12 13:10:17

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Now with 1.6.1-SNAPSHOT (8c0c9ae48f) it seems that repo owners do get a notification
for new tickets which I didn't see mentioned in the changelog but is a welcome addition.
It kinda solves this issue. It's not really intuitive but I can settle with it :)

Reported by sundayfunday1234@outlook.com on 2014-07-02 11:38:23

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

They always did - at least that is the way it was written.  I always got emails. :)
 This matches the behavior of GitHub et al.  If it is your repo you should be notified
of what is going on - that is part of ownership.

Eventually I'll code-up the personal watch/subscribe functions.  It's not hard, but
there is a precursor change that must happen first which I am less than thrilled to
do - but needs to be done.

Reported by James.Moger on 2014-07-02 13:54:51

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Strange, coz earlier I stated that "Starring the repo or being the owner of it doesn't
trigger notification emails for new tickets either." Hm, maybe it coincided with #423,
dunno.

Reported by sundayfunday1234@outlook.com on 2014-07-02 14:00:27

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Which precursor change would that be?
Because repository watches for new tickets is a feature I'd be interested in, too.
It has been requested here and the current solution is that everyone interested is
set as repo owner. Which is not the way I would want to keep it.

Reported by f.zschocke on 2014-11-18 22:36:40

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Florian, I think I was referring to Bootstrap.  The Bootstrap button bar as used by
Gitblit has bugs which prevent use of a dropdown within the bar.  A dropdown would
be quite useful here and would be familiar for Github/Bitbucket users.  I think Gitblit
uses 2.1.x which is pretty old considering the pace of trendy web development.  So
I think I meant the precursor would be to update to the final 2.x version or update
to 3.x version.  Either one would require some effort - hence I'm less than thrilled.
 :)

Reported by James.Moger on 2014-11-19 14:56:21

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

All I can say is that this is definitely the most requested feature at my workplace
ATM.

Reported by sundayfunday1234@outlook.com on 2014-11-19 22:44:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants