Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated issues in Web Project Summary #750

Closed
gitblit opened this issue Aug 12, 2015 · 7 comments
Closed

Duplicated issues in Web Project Summary #750

gitblit opened this issue Aug 12, 2015 · 7 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 454

We are currently using version 1.3.2 at git.centos.org

What steps will reproduce the problem?



1.  Normal operation, look at the right hand window for our RPMS Project here:

https://git.centos.org/project/rpms


What is the expected output? What do you see instead?

Only one entry for each Repo .. we get duplicate entries for rpms/REPO and rpms//REPO
and rpms/REPO.git. All are the same repo when clicked.

When the cache is cleared, all the duplicate entries disappear.

What version of the product are you using? On what operating system?

Version 1.3.2 on CentOS-6.5

Reported by johnny.r.hughes on 2014-06-27 18:39:29

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I'll get this fixed for 1.6.1.

Reported by James.Moger on 2014-06-27 18:43:33

  • Status changed: Accepted
  • Labels added: Milestone-1.6.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I find the leading duplicate slashes intriguing.  Is there a possibility a push is coming
in with multiple slashes in the url?

Reported by James.Moger on 2014-06-27 22:00:12

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I pushed a change to master (1.6 stable) which should eliminate the duplication....
but I am still not sure how the duplication is being triggered.

Reported by James.Moger on 2014-06-28 03:15:23

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I think all it takes to get the extra /'s is just to browse the site that way, then
it goes to cache.  The browsers ignore it, but the cache does not.

Reported by johnny.r.hughes on 2014-07-01 17:11:22

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

If you can, it would be great if you can build & test.  If you can't build then I can
send you a GO build.

Reported by James.Moger on 2014-07-01 17:12:34

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

As an example, https://git.centos.org/summary/?r=rpms/docker .. if someone puts in extra
slashes either before the rpms or between rpms and docker, it creates a new entry in
the cache.

I will get with KB and see if we can test. 

Reported by johnny.r.hughes on 2014-07-01 17:25:34

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

v1.6.1 released

Reported by James.Moger on 2014-10-20 21:36:02

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants