Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting the LDAP mail attribute doesn't delete the Gitblit user's mail attribute #752

Closed
gitblit opened this issue Aug 12, 2015 · 6 comments
Closed

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 456

If the mail attribute is empty in LDAP and then I fill it and re-login on the web UI
(which apparently triggers fetching the account details) it updates the Gitblit user's
mail attribute accordingly, but if I do it the other way around i.e. the LDAP mail
attrib is already filled and I erase it the Gitblit mail attribute will not go away.

I'm pretty sure it's not a cache problem coz the user's LDAP attrib's been empty for
weeks and Gitblit's been restarted several times ever since. The old mail attrib's
still present in Gitblit.

If I delete the mapped Gitblit user and re-login, the user will appear in the Gitblit
user list without the mail address, as it should.

Also, if I add just a simple character to the LDAP mail attrib Gitblit will change
the Gitblit user's mail attrib to that right away. So it seems like an unnecessary
check somewhere in the code.

Reported by sundayfunday1234@outlook.com on 2014-07-02 12:02:09

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I forgot to add that I'm running 1.6.1-SNAPSHOT (8c0c9ae48f).

Reported by sundayfunday1234@outlook.com on 2014-07-02 12:13:52

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hopefully fixing this for you doesn't generate complaints from other LDAP users.  LDAP
is one of the few parts of Gitblit that is a little voodoo for me.  I don't run LDAP
and it is sooo flexible/configurable that it is easy to make something work for one
group and break others.  :/

This *should* be just a straight-forward fix.

https://dev.gitblit.com/tickets/gitblit.git/134

Reported by James.Moger on 2014-07-04 15:46:32

  • Status changed: Accepted
  • Labels added: Milestone-1.6.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix pushed to master.

Reported by James.Moger on 2014-09-08 17:58:38

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

In fact, I think this also affects group membership, i.e. if I remove someone from the
LDAP git admin group, the user remains an admin in Gitblit even after re-login.

But I may be confusing things, I'll have to re-check tomorrow.

Reported by sundayfunday1234@outlook.com on 2014-09-08 18:00:48

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Okay, NVM the previous comment, I guess I was too quick testing this and the AD DCs
were still busy replicating the update or something. It works fine.

Reported by sundayfunday1234@outlook.com on 2014-09-09 12:19:27

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

v1.6.1 released

Reported by James.Moger on 2014-10-20 21:36:03

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
@flaix flaix added this to the 1.6.1 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants