New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use author date instead of commit date #919

Closed
cezariuszmarek opened this Issue Sep 17, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@cezariuszmarek

cezariuszmarek commented Sep 17, 2015

The commit list on the summary page should use author date instead of commit date to be consistent with git log output (and other tools).

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Sep 18, 2015

Owner

Interesting proposal. Right now, you are correct, Gitblit uses the committer date. This generally should show a linear date progression in the commit history and better-correlate with push events. The author date is displayed within the commit/commitdiff pages.

If you are pairing Gitblit with a Gerrit-controlled/-mirrored repo, the author date is interesting but oftentimes useless and misleading for the history of the repository.

Can you cite me an example repo where using the author date in the commit list would bring clarity?

Owner

gitblit commented Sep 18, 2015

Interesting proposal. Right now, you are correct, Gitblit uses the committer date. This generally should show a linear date progression in the commit history and better-correlate with push events. The author date is displayed within the commit/commitdiff pages.

If you are pairing Gitblit with a Gerrit-controlled/-mirrored repo, the author date is interesting but oftentimes useless and misleading for the history of the repository.

Can you cite me an example repo where using the author date in the commit list would bring clarity?

@cezariuszmarek

This comment has been minimized.

Show comment
Hide comment
@cezariuszmarek

cezariuszmarek Sep 18, 2015

It regards our private Gerrit controlled repos. Before importing repos to Gerrit I did some rebasing and rewriting to cleanup the history, so the committer date is useless for us. What's even more confusing, Git Extensions, gitk, and Git itself shows author date, so users complain, that there's something wrong with the Gitblit history view.

cezariuszmarek commented Sep 18, 2015

It regards our private Gerrit controlled repos. Before importing repos to Gerrit I did some rebasing and rewriting to cleanup the history, so the committer date is useless for us. What's even more confusing, Git Extensions, gitk, and Git itself shows author date, so users complain, that there's something wrong with the Gitblit history view.

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Sep 18, 2015

Owner

While I would still argue that commit date makes more sense to the historical progression of a branch, I will concede that conforming to a standard expectation has merit. Switched.

Owner

gitblit commented Sep 18, 2015

While I would still argue that commit date makes more sense to the historical progression of a branch, I will concede that conforming to a standard expectation has merit. Switched.

@gitblit gitblit closed this Sep 18, 2015

@cezariuszmarek

This comment has been minimized.

Show comment
Hide comment
@cezariuszmarek

cezariuszmarek Sep 18, 2015

Thanks! Maybe it should be a configuration option?

cezariuszmarek commented Sep 18, 2015

Thanks! Maybe it should be a configuration option?

@fzs fzs modified the milestone: 1.7.0 Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment