New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password with spaces got trimmed in UI #932

Closed
RainerW opened this Issue Oct 1, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@RainerW
Contributor

RainerW commented Oct 1, 2015

Wicket has a 'bug' ( https://issues.apache.org/jira/browse/WICKET-2393 ) which does by default trim PasswordTextFields (Or any Textfield in this respect ).

For Gitblit this means that a password with spaces at the end will not work.

Because this only affects the UI but NOT the git protocols, I would suggest fixing this 'hard, so gitblit would behave with all access protocols the same way.

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 1, 2015

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 1, 2015

@gitblit

This comment has been minimized.

Owner

gitblit commented Oct 1, 2015

Hi Rainer. I'm ok with the change, but it has to be consistent throughout the app. I suggest creating a class like NonTrimmedPasswordTextField which overrides the method and using that type in the following pages:

  • RootPage
  • ChangePasswordPage
  • EditUserPage

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 2, 2015

@RainerW

This comment has been minimized.

Contributor

RainerW commented Oct 2, 2015

You're right. Fixed it. Not sure how to provide the changes so you can pull ?

@gitblit

This comment has been minimized.

Owner

gitblit commented Oct 2, 2015

You'd have to rebase your changes on develop as I am not accepting changes to master anymore. Then just open a pull request.

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015

RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015

@RainerW

This comment has been minimized.

Contributor

RainerW commented Oct 8, 2015

pull request : #940

gitblit added a commit that referenced this issue Oct 9, 2015

Merge pull request #940 from RainerW/ticket-932-timedpwd
#932 do not trim passwords anywhere in the ui
@gitblit

This comment has been minimized.

Owner

gitblit commented Oct 9, 2015

Closed by #940

@gitblit gitblit closed this Oct 9, 2015

@fzs fzs added this to the 1.7.0 milestone Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment