Password with spaces got trimmed in UI #932

Closed
RainerW opened this Issue Oct 1, 2015 · 5 comments

Projects

None yet

3 participants

@RainerW
Contributor
RainerW commented Oct 1, 2015

Wicket has a 'bug' ( https://issues.apache.org/jira/browse/WICKET-2393 ) which does by default trim PasswordTextFields (Or any Textfield in this respect ).

For Gitblit this means that a password with spaces at the end will not work.

Because this only affects the UI but NOT the git protocols, I would suggest fixing this 'hard, so gitblit would behave with all access protocols the same way.

@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 1, 2015
@RainerW RainerW #932 do not trim passwords fad79b3
@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 1, 2015
@RainerW RainerW fixes #932 e76280a
@gitblit
Owner
gitblit commented Oct 1, 2015

Hi Rainer. I'm ok with the change, but it has to be consistent throughout the app. I suggest creating a class like NonTrimmedPasswordTextField which overrides the method and using that type in the following pages:

  • RootPage
  • ChangePasswordPage
  • EditUserPage
@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 2, 2015
@RainerW RainerW #932 do not trim passwords anywhere in the ui 57e6676
@RainerW
Contributor
RainerW commented Oct 2, 2015

You're right. Fixed it. Not sure how to provide the changes so you can pull ?

@gitblit
Owner
gitblit commented Oct 2, 2015

You'd have to rebase your changes on develop as I am not accepting changes to master anymore. Then just open a pull request.

@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015
@RainerW RainerW #932 do not trim passwords e98a40b
@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015
@RainerW RainerW fixes #932 3e05137
@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015
@RainerW RainerW #932 do not trim passwords anywhere in the ui 75099cb
@RainerW RainerW added a commit to RainerW/gitblit that referenced this issue Oct 8, 2015
@RainerW RainerW #932 do not trim passwords anywhere in the ui 979c75a
@RainerW
Contributor
RainerW commented Oct 8, 2015

pull request : #940

@gitblit
Owner
gitblit commented Oct 9, 2015

Closed by #940

@gitblit gitblit closed this Oct 9, 2015
@fzs fzs added this to the 1.7.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment