Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to mention other users in Tickets #985

Closed
tr4nquility opened this issue Dec 16, 2015 · 4 comments
Closed

How to mention other users in Tickets #985

tr4nquility opened this issue Dec 16, 2015 · 4 comments
Milestone

Comments

@tr4nquility
Copy link

@tr4nquility tr4nquility commented Dec 16, 2015

This one is more of a question rather than an actual issue...
So, like the title says, how do we mention others in tickets ?
Because there is filter "Mentioning You" in "My Tickets" menu, and I can't find out how to take advantage of this feature..

Thanks.

@gitblit
Copy link
Owner

@gitblit gitblit commented Dec 16, 2015

The regex that makes this work is flawed. Having said that, "@username" is what you want. You can check the preview to make sure it's matched.

@tr4nquility
Copy link
Author

@tr4nquility tr4nquility commented Dec 17, 2015

Oh ok.. Perhaps the regex flaw includes detecting usernames that contain "." in them?
I just tried it, and somehow rather confused. For example, the user that I want to mention is "Dhifa.Irawan".
In ticket description, if I write "@Dhifa.Irawan" then the link will become https://giturl/user/dhifa
instead of https://giturl/user/dhifa.irawan
And in "add a comment" section, if I try to mention "@Dhifa.Irawan" for the first time it won't work.
I must write it twice for the second mention to work. The first one will simply become a plain text.

@RedShift1
Copy link
Contributor

@RedShift1 RedShift1 commented Jan 8, 2016

I have two patches to get this started:
RedShift1@48bdd10
RedShift1@7b2160f

Note that the regex I made will work well inside sentences, but if the mention is the first or last word without any whitespace around it, it will not match. Maybe someone with more regular expression kung fu can come in and fix this.

[edit: made wrong assertion here before, ignore]

@rnveach
Copy link

@rnveach rnveach commented Oct 28, 2016

(?:^|\\s)@([^\\s]+) works for me no matter where the @ as long as it is first on the line or is preceded by a whitespace.

@flaix flaix closed this as completed in 7985115 Dec 12, 2016
@flaix flaix added this to the 1.9.0 milestone Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants