Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #964 - add missing redirect after restoring user in new session #1087

Merged
merged 1 commit into from Jun 19, 2016

Conversation

@mereth
Copy link
Contributor

@mereth mereth commented Jun 14, 2016

Hi,

I may have a fix for #964.

If web.authenticateViewPages is set to true, and when the session is invalidated due to server restart or if the max inactive interval has been reached (default 30mn) :

  • AuthorizationStrategy.isPageAuthorized save the target url and return false for any page except the homepage
  • AuthorizationStrategy.onUnauthorizedInstantiation redirect internally to the homepage
  • SessionPage.login restore user informations and the homepage is rendered

It seems it was missing the redirect to the saved target url to render the correct page

Regards

@paulsputer
Copy link
Collaborator

@paulsputer paulsputer commented Jun 19, 2016

Thanks @mereth that's a great one-liner and does appear to have fixed #964

@paulsputer paulsputer merged commit 3168c7f into gitblit:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.