New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyDashboard page bugfix for project links #110

Merged
merged 1 commit into from Aug 9, 2013

Conversation

Projects
None yet
2 participants
@douglascayers
Copy link
Contributor

douglascayers commented Aug 9, 2013

Problem:

In version 1.3.1, on the MyDashboard page, in the "projects" tab, the project name html links listed in the section are formatted wrong; they are missing the ?p= parameter. Clicking on those links redirects back to the home page (MyDashboard).

What did I expect:

To be taken to the repositories page for the project I clicked.

What code needs to change:

FilterableProjectList.fm at line 9, needs to add the ?p= url parameter.
I'm basing this on how the WicketUtils.getProjectName(PageParameters params) method works at line 457 and logic in ProjectPage.java at lines 95-98.

Although explicitly changing the url to include the query param 'p' is a simple fix, based on what I read about in GitblitParamUrlCodingStrategy and its parent class MixedParamUrlCodingStrategy, it would seem that the url path "/project/foo" should end up adding a request parameter "p=foo" as setup in GitBligWebApp line 141: mount("/project", ProjectPage.class, "p"); However, I'm not sure exactly why it doesn't seem to be happening.

bugfix to make project links go to project page and not redirect to h…
…ome page

Problem:
In version 1.3.1, on the MyDashboard page, in the "projects" tab, the project name html links listed in the section are formatted wrong; they are missing the ?p= parameter. Clicking on those links redirects back to the home page (MyDashboard).

What did I expect:
To be taken to the repositories page for the project I clicked.

What code needs to change:
FilterableProjectList.fm at line 9, needs to add the ?p= url parameter.
I'm basing this on how the WicketUtils.getProjectName(PageParameters params) method works at line 457 and logic in ProjectPage.java at lines 95-98.

Although explicitly changing the url to include the query param 'p' is a simple fix, based on what I read about in GitblitParamUrlCodingStrategy and its parent class MixedParamUrlCodingStrategy, it would seem that the url path "/project/foo" should end up adding a request parameter "p=foo" as setup in GitBligWebApp line 141: mount("/project", ProjectPage.class, "p"); However, I'm not familiar with Wicket and don't have Gitblit setup locally to build and run, so not able to debug further.
@gitblit

This comment has been minimized.

Copy link
Owner

gitblit commented Aug 9, 2013

Did you set web.mountParameters=false maybe because you are running on Tomcat?

gitblit added a commit that referenced this pull request Aug 9, 2013

Merge pull request #110 from DouglasCAyers/patch-1
MyDashboard page bugfix for project links

@gitblit gitblit merged commit 66f9418 into gitblit:master Aug 9, 2013

@douglascayers

This comment has been minimized.

Copy link
Contributor

douglascayers commented Aug 9, 2013

Thanks for the quick follow up! Yes, that was it. The mountParameters were set to false! doh!

@douglascayers douglascayers deleted the douglascayers:patch-1 branch Aug 10, 2013

gitblit added a commit that referenced this pull request Oct 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment