Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to web.xml, fix to #1132 #1178

Merged
merged 2 commits into from Jan 16, 2017
Merged

Update to web.xml, fix to #1132 #1178

merged 2 commits into from Jan 16, 2017

Conversation

@srbala
Copy link
Contributor

srbala commented Jan 16, 2017

Update to web.xml, fix to #1132

Fixes to namespace to fix xml parse error, where strict validation required

Update to web.xml, fix to #1132

Fixes to namespace to fix xml parse error, where strict validation required
@fzs

This comment has been minimized.

Copy link
Collaborator

fzs commented Jan 16, 2017

This PR fixes PR #275 which was actually a botched update to Servlet 3.0 as it only updated the version number in the file name, but not the path or the version in the declaration. It will drop Tomcat 6 support, which might not be a problem, given that Tomcat 6 was EOL'ed in 2016.

The weblogic.xml file still lists the 2.4 web-app, though. Given that it was written for Weblogic 12.1.1, which implements Java EE 6, could you also update the weblogic.xml file with the new path/version to keep the two files consistent?

@fzs fzs added this to the 1.9.0 milestone Jan 16, 2017
Update to web app 3.0 xsd
@srbala

This comment has been minimized.

Copy link
Contributor Author

srbala commented Jan 16, 2017

weblogic.xml file is updated now

@fzs fzs merged commit d0d6278 into gitblit:master Jan 16, 2017
@fzs

This comment has been minimized.

Copy link
Collaborator

fzs commented Jan 16, 2017

Thank you.

@srbala srbala deleted the srbala:patch-1 branch Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.