Retrieve LDAP groups with dereferencing aliases. #122

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@fzs
Collaborator

fzs commented Nov 11, 2013

Currently the LDAP user service will not dereference aliases when searching for groups. This patch enables
dereferencing aliases for the group search. This is benefitial if groups are defined in the DIT in a common
place but only certain ones shall play a role in Gitblit. These can now be linked under a group that can be
provided as search base for groups, without having to recreate the existing groups under the search base.

In addition, the new doSearch() method implemented in this patch also limits the attributes returned for
the gruop search to the "cn" attribute, which is the only one used. That prevents returning all the members
of the result groups, which can be a lot.

Retrieve LDAP groups with dereferencing aliases.
Currently the LDAP user service will not dereference aliases when searching for groups. This patch enables
dereferencing aliases for the group search. This is benefitial if groups are defined in the DIT in a common
place but only certain ones shall play a role in Gitblit. These can now be linked under a group that can be
provided as search base for groups, without having to recreate the existing groups under the search base.

In addition, the new doSearch() method implemented in this patch also limits the attributes returned for
the gruop search to the "cn" attribute, which is the only one used. That prevents returning all the members
of the result groups, which can be a lot.

gitblit added a commit that referenced this pull request Nov 22, 2013

Merge pull request #122 from fzs/ldap-deref-alias
Currently the LDAP user service will not dereference aliases when
searching for groups. This patch enables dereferencing aliases for the
group search. This is benefitial if groups are defined in the DIT in a
common place but only certain ones shall play a role in Gitblit. These
can now be linked under a group that can be provided as search base for
groups, without having to recreate the existing groups under the search
base.

In addition, the new doSearch() method implemented in this patch also
limits the attributes returned for the group search to the "cn"
attribute, which is the only one used. That prevents returning all the
members of the result groups, which can be a lot.

Change-Id: I29e1560390810304386dcea5ca40aaf78601b3a9
@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Nov 22, 2013

Owner

Thanks Florian, I manually merged your patch.

Owner

gitblit commented Nov 22, 2013

Thanks Florian, I manually merged your patch.

@gitblit gitblit closed this Nov 22, 2013

@fzs fzs deleted the fzs:ldap-deref-alias branch May 25, 2014

gitblit added a commit that referenced this pull request Jul 2, 2014

gitblit added a commit that referenced this pull request Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment