issue-2: Color Blame #125

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@alewis001
Contributor

alewis001 commented Dec 2, 2013

Blame output is now colored according to Commit (default), Author or
Age. Both Commit and Author output uses random colors whereas Age uses a
single (random) color with varying tints applied to indicate the age.
White indicates the most recent commit with the tint darkening as the
commits get older.

alewis001 added some commits Nov 20, 2013

issue-2: Color Blame
Blame output is now colored according to Commit (default), Author or
Age. Both Commit and Author output uses random colors whereas Age uses a
single (random) color with varying tints applied to indicate the age.
White indicates the most recent commit with the tint darkening as the
commits get older.
@alewis001

This comment has been minimized.

Show comment Hide comment
@alewis001

alewis001 Dec 2, 2013

Contributor

Ok I've made the changes as per your comments, so hopefully I've got them as you want them.

Do I need to go through and find the other languages for "gb.age" in the properties files?

Contributor

alewis001 commented Dec 2, 2013

Ok I've made the changes as per your comments, so hopefully I've got them as you want them.

Do I need to go through and find the other languages for "gb.age" in the properties files?

@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Dec 2, 2013

Owner

We'll leave that for the translators. Leaving it out makes it more
obvious what needs to be done.

Owner

gitblit commented Dec 2, 2013

We'll leave that for the translators. Leaving it out makes it more
obvious what needs to be done.

@alewis001

This comment has been minimized.

Show comment Hide comment
@alewis001

alewis001 Dec 2, 2013

Contributor

Ok no problem.

Contributor

alewis001 commented Dec 2, 2013

Ok no problem.

- <th><wicket:message key="gb.content">[content]</wicket:message></th>
+ <td class="rightAlign" style="background-color:#fbfbfb;">
+ <span class="link" style="padding-right:14px;">
+ <a wicket:id="blameByCommitLink"><wicket:message key="gb.commit">[blamebycommit]</wicket:message></a> | <a wicket:id="blameByAuthorLink"><wicket:message key="gb.author">[blamebyauthor]</wicket:message></a> | <a wicket:id="blameByAgeLink"><wicket:message key="gb.age">[blamebyage]</wicket:message></a>

This comment has been minimized.

Show comment Hide comment
@alewis001

alewis001 Dec 2, 2013

Contributor

After looking at this again I think the "[blamebyxx]" parts are wrong aren't they?

Am I right in saying I should either take them out (as the defaults are already provided in the properties file) or change them to be "[commit]", "[author]" and "[age]"?

@alewis001

alewis001 Dec 2, 2013

Contributor

After looking at this again I think the "[blamebyxx]" parts are wrong aren't they?

Am I right in saying I should either take them out (as the defaults are already provided in the properties file) or change them to be "[commit]", "[author]" and "[age]"?

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Dec 2, 2013

Owner

Those are just placeholders for your html editor. Wicket strips them out.

@gitblit

gitblit Dec 2, 2013

Owner

Those are just placeholders for your html editor. Wicket strips them out.

This comment has been minimized.

Show comment Hide comment
@alewis001

alewis001 Dec 2, 2013

Contributor

Ok I'll leave them as they are; unless you want me to do otherwise?

@alewis001

alewis001 Dec 2, 2013

Contributor

Ok I'll leave them as they are; unless you want me to do otherwise?

gitblit added a commit that referenced this pull request Dec 2, 2013

Add coloring modes to the blame page (issue-2, pull request #125)
Blame output is now colored according to Commit (default), Author or
Age. Both Commit and Author output uses random colors whereas Age uses a
single color with varying tints applied to indicate the age.  White
indicates the eldest commit with the tint darkening as the commits get
younger.

Change-Id: I045458329af4765e91d5829ce3e8d28e21eeb66e
@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Dec 2, 2013

Owner

I used this pull request as data for issue-215 so the end result to the repository is a squashed, amended merge. I also made some revisions after playing with it some more - most notable is that I reversed the age coloring so that newer code is highlighted, older code is not. This makes the age view more like a heat map.

Thanks for the contribution and closing such an old issue!

Owner

gitblit commented Dec 2, 2013

I used this pull request as data for issue-215 so the end result to the repository is a squashed, amended merge. I also made some revisions after playing with it some more - most notable is that I reversed the age coloring so that newer code is highlighted, older code is not. This makes the age view more like a heat map.

Thanks for the contribution and closing such an old issue!

@gitblit gitblit closed this Dec 2, 2013

@alewis001

This comment has been minimized.

Show comment Hide comment
@alewis001

alewis001 Dec 2, 2013

Contributor

No problem I'm glad I could help. I had a look at your modifications, looks nice!

Contributor

alewis001 commented Dec 2, 2013

No problem I'm glad I could help. I had a look at your modifications, looks nice!

@alewis001 alewis001 deleted the alewis001:issue-2 branch Dec 3, 2013

gitblit added a commit that referenced this pull request Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment