Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support nested groups on the Repositories page #1267

Closed
wants to merge 7 commits into from
Closed

Add support nested groups on the Repositories page #1267

wants to merge 7 commits into from

Conversation

martinspielmann
Copy link
Contributor

@martinspielmann martinspielmann commented Nov 6, 2017

Fix for #725.

This includes #1224 from @ybosy, because a lot of the code of it was reusable.

Also covers #527

image

(Panel contains a lot of copy-paste code from RepositoriesPanel :( But this way I was able to keep the original RepositoriesPanel without changing it a lot. ...this could be done a lot easier after a wicket upgrade in my opinion ;))

@YandexWillKillYou
Copy link

YandexWillKillYou commented Nov 9, 2017

Just got a task to realize similar functionality. Nice to see it done!

flaix added a commit to flaix/gitblit that referenced this pull request Jun 15, 2019
Fix for gitblit#725.
Also covers gitblit#527.

This is a squashed commit of the following commits,
merging and closing pull request gitblit#1267:

commit 55fee41
Author: Martin Spielmann <mail@martinspielmann.de>
Date:   Mon Nov 6 17:19:53 2017 +0100

    declared local variable final to fix travis build

commit 131e4d1
Author: Martin Spielmann <mail@martinspielmann.de>
Date:   Mon Nov 6 14:11:55 2017 +0100

    fix formatting (use tab for identation)

commit 8da5f6d
Author: Martin Spielmann <mail@martinspielmann.de>
Date:   Mon Nov 6 13:45:39 2017 +0100

    Add repositoryListType tree. Addresses gitblit#725, 527 and includes gitblit#1224

commit 6c06165
Merge: f365daa 40ee965
Author: Martin Spielmann <mail@martinspielmann.de>
Date:   Sat Nov 4 13:19:08 2017 +0100

    Merge remote-tracking branch 'collapsible/ticket/527' into 725_nested_repos

commit f365daa
Author: Martin Spielmann <mail@martinspielmann.de>
Date:   Sat Nov 4 13:10:24 2017 +0100

    first working version of tree model
@flaix
Copy link
Collaborator

flaix commented Jun 15, 2019

What would you think about listing repositories first?

Screenshot 2019-06-15 at 16 36 32

Leaving out the "guard rails" would look cleaner, but with many folders it might get difficult to see what group a repository belongs to. On the other hand, this is the opposite sorting to what one is used from a file explorer.

@flaix flaix added this to the 1.9.0 milestone Jun 15, 2019
@martinspielmann
Copy link
Contributor Author

martinspielmann commented Jun 15, 2019

I like your approach a lot. looks much better in my opinion 👍

@flaix
Copy link
Collaborator

flaix commented Jun 15, 2019

Closed by a squash merge to master in commit 0bace7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants