Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null-safe compare for ticket milestones without due date #1278

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@fschrogl
Copy link
Contributor

fschrogl commented Feb 18, 2018

When using Gitblit's Ticket system it is possible to create milestones without a due date. Doing so can result in a NullPointerException when (re)loading the tickets page, due to the not null-save TicketsMilestone comparator.

This pull request makes the comparator null-safe and orders milestones without a due date last.

@fzs fzs added this to the 1.9.0 milestone Jun 10, 2019
@fzs fzs merged commit a92a8fb into gitblit:master Jun 10, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.