New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Name / Email for LDAP (PlaceHolders) #13

Merged
merged 1 commit into from Apr 25, 2012

Conversation

Projects
None yet
2 participants
@jcrygier
Contributor

jcrygier commented Apr 25, 2012

Hi-

I've added some additional code to get the display name / email from LDAP in a nice, flexible manner (see documentation in gitblit.properties).

Also, I've added some code to escape the user name - as it was allowing for LDAP injection attacks. Please see the test case for an example of what the user could type to bypass authentication (only if passwords are stored in LDAP as clear text - unlikely, but possible).

Add logic to get display name & email (Simply stored in user model fo…
…r now).

Add code / test to defend against LDAP injection attacks.

@gitblit gitblit merged commit 7e0ce40 into gitblit:master Apr 25, 2012

gitblit added a commit that referenced this pull request Feb 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment