Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new property web.defaultOrigin. #132

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@mvdkleijn
Copy link
Contributor

commented Jan 13, 2014

The web.defaultOrigin property allows you to specify what origin name is used within the "Empty Repository" page that is displayed after creation of a repository.

Reason for PR: some people within my organization had difficulty understanding the use of "gitblit" instead of "origin" and using the standard "origin" was better for our purposes of explaining Git to users.

NOTE - I didn't know what to fill in as the SINCE value, so I left that as ??? Other than that it was tested locally and found to be working.

Adding new property web.defaultOrigin.
The web.defaultOrigin property allows you to specify what origin name
is used within the "Empty Repository" page that is displayed after
creation of a repository.
@gitblit

This comment has been minimized.

Copy link
Owner

commented Jan 13, 2014

Actually, I think these pages (per-translation) should be changed. I don't see the value in creating a config option for specifying the remote name. I would favor just hard-coding it as origin and improving the instructions to include setting upstream.

@mvdkleijn

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2014

That's fine from my perspective too. I assumed you had a specific reason for this setup.

Want me to open a new PR in which I hardcode origin and improve the html pages to include additional instructions?

@gitblit

This comment has been minimized.

Copy link
Owner

commented Jan 13, 2014

Yeah, that would be great. There must have been some reason I did that... but I can't remember. Today, I think it is dumb so lets change it. :)

@mvdkleijn

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2014

No problem. I'm closing this PR in favor of a new one I'll make to change the hardcoded entry into origin and I'll add some improved instructions on how to add an upstream if applicable.

@mvdkleijn mvdkleijn closed this Jan 13, 2014

@mvdkleijn mvdkleijn deleted the mvdkleijn:defaultOrigin branch Jan 13, 2014

@mvdkleijn

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2014

New PR at #133

gitblit added a commit that referenced this pull request Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.