Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Defined Repository Properties (Issue #92) #16

Merged
merged 6 commits into from May 9, 2012

Conversation

@jcrygier
Copy link
Contributor

jcrygier commented May 7, 2012

This is a full solution for custom fields as discussed in issue #92 (mainly used for groovy hooks). Please see http://code.google.com/p/gitblit/issues/detail?id=92 for details.

@gitblit
Copy link
Owner

gitblit commented May 7, 2012

Where did you get VerticalFlowLayout? I can't merge that because it looks like copy-and-paste from somewhere else without any license information nor attribution.

@jcrygier
Copy link
Contributor Author

jcrygier commented May 7, 2012

Sorry, I grabbed it originally from Stack Overflow (http://stackoverflow.com/questions/8196530/java-vertical-flowlayout-with-horizontal-scrolling). Looks like it originally came from a google code (http://code.google.com/p/verticalflowlayout/source/browse/trunk/src/VerticalFlowLayout.java - LGPL license) which is a slight modification of FlowLayout from Sun.

I can use a different implementation if you prefer, but this one looked the most visually appealing. Or if you prefer me to slap copyrights, I can do that too.

@gitblit
Copy link
Owner

gitblit commented May 7, 2012

IANAL, but IMHO the application of LGPL here is invalid. The "verticalflowlayout" project can't take Sun code, tweak it, and relicense as LGPL because they want to. Especially when you read the first 4 lines of the header:

/*

  • @(#)VerticalFlowLayout.java 1.52 03/12/19
    *
  • Copyright 2004 Sun Microsystems, Inc. All rights reserved.
  • SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
    */

I think we'll need a different approach for laying out this panel.

@jcrygier
Copy link
Contributor Author

jcrygier commented May 7, 2012

Yeah, I totally agree. I should have dug into that a bit deeper before, my apologies. I'll get that fixed right up ASAP.

@jcrygier
Copy link
Contributor Author

jcrygier commented May 7, 2012

Alright, I've moved to a standard BoxLayout. However, to get rid of some really ugly gaps on the UI, I had to do some "swing math" to add a filler.

gitblit added a commit that referenced this pull request May 9, 2012
Custom Defined Repository Properties (Issue #92)
@gitblit gitblit merged commit 5f22725 into gitblit:master May 9, 2012
This was referenced Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.