Initial Release for My Tickets #171

Closed
wants to merge 0 commits into
from

Conversation

Projects
None yet
2 participants
@Hybris95
Contributor

Hybris95 commented Apr 15, 2014

Simple "My Tickets" view.
Can be accessed via /mytickets (yet).

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Apr 16, 2014

Owner

I'll take a closer look at this after the 1.5.0 release which should be out by the end of the week.

Owner

gitblit commented Apr 16, 2014

I'll take a closer look at this after the 1.5.0 release which should be out by the end of the week.

@Hybris95

This comment has been minimized.

Show comment
Hide comment
@Hybris95

Hybris95 Apr 16, 2014

Contributor

Should I rebase my commits when 1.5.0 is out or will you manage to rewrite the commits ?

Contributor

Hybris95 commented Apr 16, 2014

Should I rebase my commits when 1.5.0 is out or will you manage to rewrite the commits ?

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Apr 16, 2014

Owner

Sure, why not.

Owner

gitblit commented Apr 16, 2014

Sure, why not.

@Hybris95

This comment has been minimized.

Show comment
Hide comment
@Hybris95

Hybris95 Apr 18, 2014

Contributor

Commits were rebased.

Contributor

Hybris95 commented Apr 18, 2014

Commits were rebased.

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Apr 22, 2014

Owner

Hi Christian,

I think the My Tickets page is a pretty large and complex feature - that is why I didn't include it in 1.4.0. It would have delayed me several more weeks. I've pushed a branch with your commits plus a revision commit where I have revised some of your approach. It is still very rough/primitive and a long way from mergeable. We should be aiming to have something as functional as the standard Tickets page, but streamlined for things relevant to the current user.

Things to consider in My Tickets....

  1. anonymous users are irrelevant - there is no "my" for an anonymous user. We should redirect AND not bother showing the link for anon users.
  2. repositories with work trees can be ignored
  3. we should use the Lucene index rather than mining tickets directly - that won't scale.

The Lucene index does not keep track of who votes, so we can't query for your voted tickets, but all other ticket attributes should be represented.

It might be helpful for you to have real ticket data when working on this. One way you can do this is to clone my repo - but you'll have to use the BranchTicketService.

git clone --mirror https://dev.gitblit.com/r/gitblit.git

After you clone, run the ReindexTickets tool. This will reindex all tickets from all repos using your configured service - which should be BranchTicketService, if using my data.

-J

Owner

gitblit commented Apr 22, 2014

Hi Christian,

I think the My Tickets page is a pretty large and complex feature - that is why I didn't include it in 1.4.0. It would have delayed me several more weeks. I've pushed a branch with your commits plus a revision commit where I have revised some of your approach. It is still very rough/primitive and a long way from mergeable. We should be aiming to have something as functional as the standard Tickets page, but streamlined for things relevant to the current user.

Things to consider in My Tickets....

  1. anonymous users are irrelevant - there is no "my" for an anonymous user. We should redirect AND not bother showing the link for anon users.
  2. repositories with work trees can be ignored
  3. we should use the Lucene index rather than mining tickets directly - that won't scale.

The Lucene index does not keep track of who votes, so we can't query for your voted tickets, but all other ticket attributes should be represented.

It might be helpful for you to have real ticket data when working on this. One way you can do this is to clone my repo - but you'll have to use the BranchTicketService.

git clone --mirror https://dev.gitblit.com/r/gitblit.git

After you clone, run the ReindexTickets tool. This will reindex all tickets from all repos using your configured service - which should be BranchTicketService, if using my data.

-J

@Hybris95

This comment has been minimized.

Show comment
Hide comment
@Hybris95

Hybris95 Apr 22, 2014

Contributor

I forked the branch "mytickets" on my own repo, and squashed all the commits done until then since you imported them in your own "mytickets" branch.

I think this pull request can be closed.

I will work soon on improving my initial system with the directives you gave me.

Contributor

Hybris95 commented Apr 22, 2014

I forked the branch "mytickets" on my own repo, and squashed all the commits done until then since you imported them in your own "mytickets" branch.

I think this pull request can be closed.

I will work soon on improving my initial system with the directives you gave me.

@Hybris95 Hybris95 closed this Apr 22, 2014

gitblit added a commit that referenced this pull request Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment