New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to make the Git repo URL configurable #203

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@svogt
Contributor

svogt commented Jun 18, 2014

When Gerrit and Gitblit are deployed on the same server /r/ might be used by Gerrit. Add a config setting to change the shown URL to another primary URL

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Jun 18, 2014

Owner

This one is a little trickier. The implication is that configuring that url path apples to the actual mounted path in web.xml - which it does not and can not.... yet. I've been working on eliminating most of web.xml by integrating Guice 1 as a replacement for Dagger. There are a few reasons why Dagger is handicapping growth. I'm going to hold-off on merging this PR until I have integrated Guice. Once I have that completed then this setting will have more value since it will legitimately apply to the mounted path and not just the displayed path.

Owner

gitblit commented Jun 18, 2014

This one is a little trickier. The implication is that configuring that url path apples to the actual mounted path in web.xml - which it does not and can not.... yet. I've been working on eliminating most of web.xml by integrating Guice 1 as a replacement for Dagger. There are a few reasons why Dagger is handicapping growth. I'm going to hold-off on merging this PR until I have integrated Guice. Once I have that completed then this setting will have more value since it will legitimately apply to the mounted path and not just the displayed path.

gitblit added a commit that referenced this pull request Oct 7, 2014

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit May 27, 2015

Owner

@svogt did you still need this functionality? While it is true that both Gitblit and Gerrit use /r/ they both can't be mounted on the same context path so I'm not sure if the motivation in the description is enough to justify adding this setting.

Owner

gitblit commented May 27, 2015

@svogt did you still need this functionality? While it is true that both Gitblit and Gerrit use /r/ they both can't be mounted on the same context path so I'm not sure if the motivation in the description is enough to justify adding this setting.

@gitblit gitblit closed this Jun 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment