Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upStartTLS is not supported in LdapUserService (issue 122) #23
Conversation
gitblit
merged commit 845b532
into
gitblit:master
Aug 9, 2012
This comment has been minimized.
This comment has been minimized.
|
Thanks for the contribution! I'll try to figure out unit testing StartTLS later. Based on the documentation link you provided it looks like pretty straight-forward/boilerplate code and I'm pretty sure that UnboundID has thoroughly tested that. |
added a commit
that referenced
this pull request
May 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
StephenKing commentedAug 9, 2012
By providing an URL in the format "ldap+tls://ldapserver.example.com",
you can now connect to LDAP servers that require StartTLS command.
See http://code.google.com/p/gitblit/issues/detail?id=122
P.S: I was not able to execute JUnit tests, they also do not work without my patch (do I need an LDAP server on localhost with the expected structure?). So forgive me, if sth. went wrong - but this code works with our OpenLDAP server.