New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartTLS is not supported in LdapUserService (issue 122) #23

Merged
merged 1 commit into from Aug 9, 2012

Conversation

Projects
None yet
2 participants
@StephenKing
Contributor

StephenKing commented Aug 9, 2012

By providing an URL in the format "ldap+tls://ldapserver.example.com",
you can now connect to LDAP servers that require StartTLS command.

See http://code.google.com/p/gitblit/issues/detail?id=122

P.S: I was not able to execute JUnit tests, they also do not work without my patch (do I need an LDAP server on localhost with the expected structure?). So forgive me, if sth. went wrong - but this code works with our OpenLDAP server.

StartTLS is not supported in LdapUserService (issue 122)
By providing an URL in the format "ldap+tls://ldapserver.example.com",
you can now connect to LDAP servers that require StartTLS command.

@gitblit gitblit merged commit 845b532 into gitblit:master Aug 9, 2012

@gitblit

This comment has been minimized.

Owner

gitblit commented Aug 9, 2012

Thanks for the contribution! I'll try to figure out unit testing StartTLS later. Based on the documentation link you provided it looks like pretty straight-forward/boilerplate code and I'm pretty sure that UnboundID has thoroughly tested that.

gitblit added a commit that referenced this pull request May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment