Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for fix of http performance problem #246

Merged
merged 1 commit into from Mar 7, 2015

Conversation

@pierreyvesbaloche
Copy link

@pierreyvesbaloche pierreyvesbaloche commented Mar 6, 2015

Hi James,

I'm a coworker of Johann Ollivier Lapeyre (from the discussion https://groups.google.com/forum/#!topic/gitblit/eEGZpiApDTQ) and I have the following patch to suggest.
I tried it locally and it moved in our test environnent from 11s down to 2s for a user connection.

Best regards

Pierre-yves Baloche

@gitblit
Copy link
Owner

@gitblit gitblit commented Mar 6, 2015

Looks great. Can we swallow the exceptions in checksum and not bubble them up? All Java implementations are required to have an SHA1 digest implementation so those exceptions should never trigger.

@gitblit gitblit merged commit f6cbed8 into gitblit:master Mar 7, 2015
@gitblit
Copy link
Owner

@gitblit gitblit commented Mar 7, 2015

I adjusted your contribution a little. Thanks!

@pierreyvesbaloche
Copy link
Author

@pierreyvesbaloche pierreyvesbaloche commented Mar 9, 2015

Glad I could help ;-) Of course your modifications were well appropriated. Cheers.

@bviktor

This comment has been minimized.

Copy link

@bviktor bviktor commented on f6cbed8 Mar 16, 2015

Sweet, I've also noticed that pushes take a few seconds even for minimal changes. I can't wait to see whether this will improve our instance as well.

@bviktor

This comment has been minimized.

Copy link
Contributor

@bviktor bviktor commented on f6cbed8 Mar 16, 2015

Sweet, I've also noticed that pushes take a few seconds even for minimal changes. I can't wait to see whether this will improve our instance as well.

@Benjamin321
Copy link

@Benjamin321 Benjamin321 commented Dec 10, 2015

Thank you for this patch. With about 30 active (of 100) users and more then 1500 repositories, push and pull sometimes needed more then a minute to complete. Regular time for requests was around 30 seconds.
In the monitoring I saw a lot of read/write traffic on the users.conf. After upgrading to 1.7.1 traffic has become way less and push/pull requests rarely need more then five seconds.

@flaix flaix modified the milestone: 1.7.0 Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.