Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dependencies #269

Closed
wants to merge 2 commits into from
Closed

Updated Dependencies #269

wants to merge 2 commits into from

Conversation

@wangliyu
Copy link

wangliyu commented Jun 9, 2015

Groovy 2.4.3
JGit 4.0.0.201506090130-r
SLF4j 1.7.12
Wicket 1.4.23

Groovy 2.4.3
JGit 4.0.0.201506090130-r
SLF4j 1.7.12
Wicket 1.4.23
@wangliyu

This comment has been minimized.

Copy link
Author

wangliyu commented Jun 9, 2015

As part of Eclipse mars release, the JGit is released 4.0, there is a big change:
https://dev.gitblit.com/commit/mirrors!jgit.git/686124bec32fcdee1545e7d9c312dcf0276b44af
that cause gitblit compile error, also Groovy has updated to 2.4.3, Wicket 1.4.23, SLF4j 1.7.12, Please review and merge it in, also Since JGit 4.0, most of the class implemented AutoClosable interfaces, which means we can use try-with-resources feature from Java7. maybe need more tweak.

@gitblit

This comment has been minimized.

Copy link
Owner

gitblit commented Jun 9, 2015

I don't know that I am ready for JGit 4.0 yet. Maybe.

@wangliyu

This comment has been minimized.

Copy link
Author

wangliyu commented Jun 9, 2015

I'll run the new change in my env for couple days see how it goes, I'm using GO version - with Java8.

@wangliyu

This comment has been minimized.

Copy link
Author

wangliyu commented Jun 9, 2015

here is the highlight of changes in 4.0:
https://wiki.eclipse.org/JGit/New_and_Noteworthy/4.0

@wangliyu

This comment has been minimized.

Copy link
Author

wangliyu commented Jun 10, 2015

I run the new build in my env, it works fine. clone/push/create branch/tag all are fine.

@gitblit

This comment has been minimized.

Copy link
Owner

gitblit commented Jun 11, 2015

I want to sit on updating to JGit 4.0. I know there is at least one intermittent bug in it that would affect my normal usage workflow. As for Guice 4.0, you may or may not have noticed that Gitblit uses a patched build of guice-servlet. In order to safely update to Guice 4.0 we'd need to apply that patch to the 4.0 code base.

The other dependency update proposals are fine.

cc @gzsombor

@gitblit

This comment has been minimized.

Copy link
Owner

gitblit commented Jun 15, 2015

@wangliyu Please submit a new PR against develop without JGit 4 and without Guice 4.

@gitblit gitblit closed this Jun 15, 2015
@gitblit gitblit mentioned this pull request Jun 16, 2015
@wangliyu wangliyu deleted the wangliyu:develop branch Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.