allow internal privilege evaluation external URLs #280

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@mrjoel
Collaborator

mrjoel commented Jun 29, 2015

commit c20191f enabled support
for hiding internal URLs, but didn't consider that it broke the
evaluation of permissions (used for tickets, etc.), and caused
a NPE on repoUrl.permission when trying to view the TicketPage.

With all internal mechanisms disabled, it would result in the
first URL being external with unknown permissions. This adds an
option to use internal permissions even for external URLs.

Note that this does not grant any additional permissions, but
does offer the option to have gitblit advertise the full set of
what is allowed, even if the external URL imposes additional
restrictions.

allow internal privilege evaluation external URLs
commit c20191f enabled support
for hiding internal URLs, but didn't consider that it broke the
evaluation of permissions (used for tickets, etc.), and caused
a NPE on repoUrl.permission when trying to view the TicketPage.

With all internal mechanisms disabled, it would result in the
first URL being external with unknown permissions. This adds an
option to use internal permissions even for external URLs.

Note that this does not grant any additional permissions, but
does offer the option to have gitblit advertise the full set of
what is allowed, even if the external URL imposes additional
restrictions.

@mrjoel mrjoel closed this Jun 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment