New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP email attribute from LDAP? #40

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@marcomsousa

marcomsousa commented Oct 3, 2012

LDAP email attribute from LDAP?

@jcrygier

This comment has been minimized.

Contributor

jcrygier commented Oct 4, 2012

Looking at this change, I believe the code would act the same...so I wouldn't call this a fix. Actually, using the attribute directly (i.e. no ${} notation) is slightly more efficient (it doesn't have to loop over every LDAP Attribute). Was this not working for you?

Also, being a properties file, changing might mess with people who aren't customizing their properties, so this has a minor chance of causing a difficult upgrade (minor since it's confined to LDAP, and it's just an email attribute). I would vote to NOT include this change, but for you to customize the properties for your environment.

@marcomsousa

This comment has been minimized.

marcomsousa commented Oct 4, 2012

without the ${email} attribute don't work for me...

@jcrygier

This comment has been minimized.

Contributor

jcrygier commented Oct 4, 2012

Hmmmm, have you had a chance to debug in your environment? LdapUserService L270 should be pulling out your email from an attribute on the LDAP entry. Your variable "email" (Line 262) should be "email" with the default settings.

@gitblit

This comment has been minimized.

Owner

gitblit commented May 31, 2013

It's been 8 months since the report and there is insufficient evidence that this change is necessary. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment