Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "all repositories" parameter #935

Merged
merged 1 commit into from Oct 5, 2015
Merged

Conversation

@vitalif
Copy link

vitalif commented Oct 1, 2015

Currently in Gitblit you must explicitly list all repositories to search in them. This does not allow to conveniently link to search page, for example, from a bugtracker. This patch adds "in all repositories" parameter so you can link to /lucene/?allrepos=1&query=$q or select a checkbox in the UI :)

@@ -48,6 +48,7 @@ gb.password = password
gb.tagger = tagger
gb.moreHistory = more history...
gb.difftocurrent = diff to current
gb.allrepos = in all repositories

This comment has been minimized.

@gitblit

gitblit Oct 1, 2015 Owner

Let's tweak this to "All Repositories" so that it can be used elsewhere in the app, if needed.

@gitblit
Copy link
Owner

gitblit commented Oct 1, 2015

@vitalif This looks great. Make the small tweak and I'll merge.

@vitalif
Copy link
Author

vitalif commented Oct 1, 2015

There's an additional defect which should also be fixed: current implementation can duplicate the same repository multiple times in searchRepositories. In fact, you can even pass the same repository multiple times in the query parameter: /lucene/?query=xxx&repositories=repo+repo+repo, and it will lead to duplicate search results :)

@gitblit gitblit merged commit b4d9581 into gitblit:develop Oct 5, 2015
@paulsputer paulsputer mentioned this pull request Apr 14, 2016
9 of 9 tasks complete
@flaix flaix modified the milestone: 1.7.0 Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.