New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor authentication for servlet HTTP header handler #980

Merged
merged 3 commits into from Dec 10, 2015

Conversation

Projects
None yet
3 participants
@mrjoel
Collaborator

mrjoel commented Dec 9, 2015

This is an update of #273, nearly identical except updated to work with #908 as indicated in the original.

mrjoel added some commits Jun 12, 2015

remove external account type in lieu of specific type
This was unused and causing provider lookup to fail in
AuthenticationManager.findProvider() by changing it out
from underneath. As a result, the supportXChanges methods
weren't being reported correctly.
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Dec 10, 2015

Owner

Nice & clean. Great job.

Owner

gitblit commented Dec 10, 2015

Nice & clean. Great job.

gitblit added a commit that referenced this pull request Dec 10, 2015

Merge pull request #980 from mrjoel/mrjoel-httpheaders
Refactor authentication for servlet HTTP header handler

@gitblit gitblit merged commit 7b7b0d5 into gitblit:master Dec 10, 2015

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Dec 10, 2015

Owner

I granted you contributor access for easier branch-based PRs rather than from forks. Thanks for all your contributions.

Owner

gitblit commented Dec 10, 2015

I granted you contributor access for easier branch-based PRs rather than from forks. Thanks for all your contributions.

@mrjoel mrjoel deleted the mrjoel:mrjoel-httpheaders branch Dec 10, 2015

@paulsputer paulsputer referenced this pull request Apr 14, 2016

Closed

Preparation for 1.8.0 release #1043

9 of 9 tasks complete

@fzs fzs modified the milestone: 1.8.0 Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment