New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #978 - HTML5 date input support #982

Merged
merged 1 commit into from Dec 10, 2015

Conversation

Projects
None yet
4 participants
@paulsputer
Collaborator

paulsputer commented Dec 9, 2015

  • JS patch/hack to coerce legacy wicket into talking to a HTML5 input type
  • JS script to hide inline help on date format when using HTML5 date picker
    • Date picker shown in user locale and standard does not support custom
      format.
    • Always sent in ISO8601 format
fix for #978 - HTML5 date input support
+ JS patch/hack to coerce legacy wicket into talking to a HTML5 input type
+ JS script to hide inline help on date format when using HTML5 date picker
  + Date picker shown in user locale and standard does not support custom
  format.
  + Always sent in ISO8601 format
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Dec 10, 2015

Owner

👍 Gorgeous. Now if only all the browsers had the Chrome date picker.

Owner

gitblit commented Dec 10, 2015

👍 Gorgeous. Now if only all the browsers had the Chrome date picker.

gitblit added a commit that referenced this pull request Dec 10, 2015

@gitblit gitblit merged commit 63e4d96 into master Dec 10, 2015

@bviktor

This comment has been minimized.

Show comment
Hide comment
@bviktor

bviktor Dec 10, 2015

Contributor

Does that work in Blink-based browsers, e.g. Opera?

Contributor

bviktor commented Dec 10, 2015

Does that work in Blink-based browsers, e.g. Opera?

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Dec 10, 2015

Owner

Blink-based, should. That's Chrome's engine now, right? Presto-based, no idea; I no longer test Opera.

Owner

gitblit commented Dec 10, 2015

Blink-based, should. That's Chrome's engine now, right? Presto-based, no idea; I no longer test Opera.

@paulsputer

This comment has been minimized.

Show comment
Hide comment
@paulsputer

paulsputer Dec 10, 2015

Collaborator

@bviktor according to http://caniuse.com/#search=date Opera is supported, though I've not confirmed this. I tested:

Chrome - Supported
Edge - Supported
Firefox - Fall back to textbox (see https://bugzilla.mozilla.org/show_bug.cgi?id=825294)
IE - Fall back to textbox

Collaborator

paulsputer commented Dec 10, 2015

@bviktor according to http://caniuse.com/#search=date Opera is supported, though I've not confirmed this. I tested:

Chrome - Supported
Edge - Supported
Firefox - Fall back to textbox (see https://bugzilla.mozilla.org/show_bug.cgi?id=825294)
IE - Fall back to textbox

@paulsputer paulsputer deleted the 978-milestone-date-selector branch Dec 10, 2015

@bviktor

This comment has been minimized.

Show comment
Hide comment
@bviktor

bviktor Dec 10, 2015

Contributor

Opera is Blink-based :) Thanks for the report, @paulsputer , and also for all these nice additions recently :)

Contributor

bviktor commented Dec 10, 2015

Opera is Blink-based :) Thanks for the report, @paulsputer , and also for all these nice additions recently :)

@fzs fzs modified the milestone: 1.8.0 Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment