Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit data on line chart #122

Closed
david23zhu opened this Issue Jul 31, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@david23zhu
Copy link

david23zhu commented Jul 31, 2017

Hello,

This library is amazing and has been a great help to us! Thanks for the great work!

Recently we encountered a issue when we try to Edit Data on the generated line chart, the line chart will disappear, and there is no data found in the opened excel window, it works for bar chart and pie chart.

Examples can be found in PptxGenJS-master Demo Examples. Please help, many thanks.

@gitbrent gitbrent self-assigned this Aug 1, 2017

@gitbrent gitbrent added the bug label Aug 1, 2017

@gitbrent gitbrent added this to the 1.7.0 milestone Aug 1, 2017

gitbrent pushed a commit that referenced this issue Aug 1, 2017

@gitbrent

This comment has been minimized.

Copy link
Owner

gitbrent commented Aug 1, 2017

Hi @david23zhu,

Thanks for opening an issue for this - and thanks for the kind words!

The library was not creating the underlying Excel workbooks correctly for both LINE and AREA charts. That has been fixed in the newest codebase.

Please give it a try and let me know if everything works now.

gitbrent pushed a commit that referenced this issue Aug 1, 2017

@david23zhu

This comment has been minimized.

Copy link
Author

david23zhu commented Aug 2, 2017

Hello Brent,

Thanks for your fix. I have tried the new code unfortunately it's still not working for Line Chart and Area Chart, there is no new excel window showing up after selecting Edit Data.

gitbrent pushed a commit that referenced this issue Aug 4, 2017

gitbrent pushed a commit that referenced this issue Aug 6, 2017

GitBrent GitBrent
Fix for Issue #122
Area and Line chart data (the embedded xlsx) is editable in O365 now.

gitbrent pushed a commit that referenced this issue Aug 7, 2017

GitBrent GitBrent
Issue #122
More work on xlsx export file

gitbrent pushed a commit that referenced this issue Aug 7, 2017

GitBrent GitBrent
Issue #122
More work on edit issue

gitbrent pushed a commit that referenced this issue Aug 8, 2017

GitBrent GitBrent
Fixed Issue #122
All chart formats are editable in PPT-2013
@gitbrent

This comment has been minimized.

Copy link
Owner

gitbrent commented Aug 8, 2017

Hi @david23zhu

Thanks for testing. All chart formats are editable now.

@gitbrent gitbrent closed this Aug 8, 2017

@david23zhu

This comment has been minimized.

Copy link
Author

david23zhu commented Aug 8, 2017

@gitbrent Many thanks!! It works wonderfully now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.