Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typescript declaration files #409

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
3 participants
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Sep 25, 2018

Hi! We're using PptxGenJs in a typescript project and made a couple changes to the declaration files.

@gitbrent gitbrent self-assigned this Sep 26, 2018

@gitbrent gitbrent self-requested a review Sep 26, 2018

@gitbrent gitbrent added this to the 2.4.0 milestone Sep 26, 2018

@antiremy

This comment has been minimized.

Copy link

antiremy commented Oct 6, 2018

Sorry for the ignorance, but can we get some instructions on how/when to use these files?

@michaelbeaumont

This comment has been minimized.

Copy link
Contributor Author

michaelbeaumont commented Oct 8, 2018

Well they're for TypeScript, and once you're using TS you don't have to do anything.

@gitbrent gitbrent merged commit b40d8cb into gitbrent:master Oct 12, 2018

gitbrent added a commit that referenced this pull request Oct 12, 2018

@gitbrent

This comment has been minimized.

Copy link
Owner

gitbrent commented Oct 12, 2018

Thanks @michaelbeaumont !

You did a terrific job of upgrading that amateur defs I had in there... :-)

gitbrent added a commit that referenced this pull request Oct 12, 2018

@michaelbeaumont michaelbeaumont deleted the factisresearch:fix_dts branch Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.