Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder left align property needs fixing #417

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@raphael-trzpit
Copy link
Contributor

commented Oct 11, 2018

I had a problem when using a title placeholder in a master slide:

var pptx = new PptxGenJS();
pptx.defineSlideMaster({
  title: 'MASTER_SLIDE',
  objects: [
    { 'placeholder': {
        options: { name:'title', type:'title', x:0.6, y:1.5, w:12, h:5.25, align: 'left' },
        text: '(custom placeholder text!)'
      }
    }
  ]
});
pptx.addNewSlide('MASTER_SLIDE');
pptx.save();

When i open the file, the align property is not precised and the default behavior seems to be centered.
As the left case is ignored, i can't force it :(

@gitbrent gitbrent self-assigned this Oct 12, 2018

@gitbrent gitbrent added the bug label Oct 12, 2018

@gitbrent gitbrent added this to the 2.4.0 milestone Oct 12, 2018

@gitbrent gitbrent merged commit 0cea814 into gitbrent:master Oct 12, 2018

@gitbrent

This comment has been minimized.

Copy link
Owner

commented Oct 12, 2018

Thanks @raphael-trzpit !

@gitbrent gitbrent changed the title fix: Also add the left align property when generating xml paragraph p… Placeholder left align property needs fixing Oct 12, 2018

gitbrent added a commit that referenced this pull request Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.