Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix colspan/rowspan #852

Merged
merged 7 commits into from Dec 6, 2020
Merged

fix colspan/rowspan #852

merged 7 commits into from Dec 6, 2020

Conversation

wangfengming
Copy link
Contributor

  • fix colspan and rowspan
  • self-close <a:rPr/> when no child

@wangfengming
Copy link
Contributor Author

wangfengming commented Oct 17, 2020

image
the first cell has options: rowspan=2 colspan=2

  • for cell(0,0): <a:tc> should has rowSpan=2 gridSpan=2 attributes
  • for cell(0,1): a dummy cell, <a:tc> should has rowSpan=2 hMerge=1 attributes
  • for cell(1,0): a dummy cell, <a:tc> should has vMerge=1 gridSpan=2 attributes
  • for cell(1,1): a dummy cell, <a:tc> should has vMerge=1 hMerge=1

@gitbrent gitbrent merged commit 279a1d5 into gitbrent:master Dec 6, 2020
@gitbrent
Copy link
Owner

gitbrent commented Dec 6, 2020

Thanks @wangfengming !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants