Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request reviewers support #1728

Open
KubaWojnowski opened this issue Oct 1, 2017 · 3 comments
Open

Pull request reviewers support #1728

KubaWojnowski opened this issue Oct 1, 2017 · 3 comments
Labels

Comments

@KubaWojnowski
Copy link

@KubaWojnowski KubaWojnowski commented Oct 1, 2017

It will be great if gitbucket will support simple review feature:
For protected branches pull request can be merged only by users with "pull request review" privileges.

It can be realized for example by:

  1. Adding new "Reviewer" role to repository collaborators groups/users.
    "Reviewer" role will have all Developer's role privileges and additional privilege to merge pull request on protected branches.
    image

  2. Adding "Review to merge" option to repository: Settings -> Branches
    image

@takezoe takezoe added the feature label Oct 2, 2017
@kmasuyama

This comment has been minimized.

Copy link

@kmasuyama kmasuyama commented Mar 8, 2019

I'd love to see this implemented.

From the GitHub implementation, I think the following features would also be useful:

  • number of required reviews
  • dismiss stale reviews
@marmartins

This comment has been minimized.

Copy link

@marmartins marmartins commented Oct 16, 2019

This would be very useful. Great guys.

@alwibrm

This comment has been minimized.

Copy link

@alwibrm alwibrm commented Oct 28, 2019

It would be nice to have an "reject" option, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.