New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display ads locally between these hours #292

Merged
merged 3 commits into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@coderberry
Copy link
Contributor

coderberry commented Aug 31, 2018

No description provided.

coderberry and others added some commits Aug 31, 2018

@coderberry
Copy link
Contributor

coderberry left a comment

Looks awesome.. 2 questions

modified_query =
AdService.Query.TimeManagement.where_accepted_hours_for_ip_address(
query,
{72, 229, 28, 185}

This comment has been minimized.

@coderberry

coderberry Aug 31, 2018

Contributor

will this test only pass during certain hours of the day?

modified_query =
AdService.Query.TimeManagement.where_accepted_hours_for_ip_address(
query,
{95, 31, 18, 119}

This comment has been minimized.

@coderberry

coderberry Aug 31, 2018

Contributor

Will this test only pass during certain times of day?

@StareIntoTheBeard StareIntoTheBeard merged commit 9b785f6 into master Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@coderberry coderberry deleted the berry/local-tz-ads branch Sep 5, 2018

@coderberry coderberry changed the title [WIP] Only display ads locally between these hours Only display ads locally between these hours Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment