Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontawesome : Revert to css #1331

Closed
thelostone-mc opened this issue Jun 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@thelostone-mc
Copy link
Member

commented Jun 1, 2018

User Story

Font awesome 5 js seems to be needing optimization.
Seeing lots of console warnings for violations where events take longer than expected.

screen shot 2018-06-01 at 1 07 51 pm

Refs: chrisblakley/Nebula#1582

Potential Fix: Revert back to the CSS method until js svg is optimized and proven worthy of migration

@thelostone-mc thelostone-mc self-assigned this Jun 1, 2018

@thelostone-mc

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2018

@SaptakS @mbeacom could you guys tell me if this happens at your end ?
If yes -> I'll change it to CSS font-awesome as against the JS svg (Both are font-awesome 5)

@SaptakS context :

We moved from FontAwesome 4 to 5 cause they had more icons and it was lighter.
They have 2 impl -> CSS (same old) & JS + SVG (<i> tag -> replaced by <svg> tag , supposed to be faster , ligher + tree shaking )
Decided to go with the JS and now debating if we should shift to the CSS implementation

Noticed this a while back and not a fan of the flooded console.log 😅

@SaptakS

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2018

@thelostone-mc I know this problem exactly and have faced it in many other open source projects I worked in. The JS as you mentioned does a whole lotta complicated work which ain't needed. And they actually have a CSS only module as well in the version 5. So we can just use that. The font classes and everything remains same. I have had experience in doing this migration, so let me know in case you need any kind of help. :)

@thelostone-mc thelostone-mc referenced this issue Jun 1, 2018

Merged

fontawesome: revert to css #1333

6 of 6 tasks complete

@gitcoinco gitcoinco deleted a comment from darkdarkdragon Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.