Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New avatar assets #1663

Closed
4 tasks
mbeacom opened this issue Jul 9, 2018 · 22 comments
Closed
4 tasks

New avatar assets #1663

mbeacom opened this issue Jul 9, 2018 · 22 comments
Labels
good first issue This a good first issue for a community newcomer.

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Jul 9, 2018

User Story

As a user, I want to new avatar assets to show off and express myself digitally.

Description

Type: New implementation

Definition of Done

  • Create an .svg asset and place it in app/assets/v2/images/avatar/<category>
  • Add the SVG asset as a .txt Django template in app/avatar/templates/<category>/<item|index>.txt with variable fill.
  • Add your asset to utils.py
  • Provide a screenshot of the new asset from the avatar builder AND the profile details page on this Github issue.

Additional Information

Feel free to submit any assets you would like to see on Gitcoin. If the asset is accepted, your asset will become a part of the live avatar builder! All other assets will be escalated to the core team for review and potential modification.

See the avatar item request shortlist

COMMUNITY MEMBERS
Feel free to add reactions/upvote your favorite new avatar items/assets!

@PixelantDesign PixelantDesign added the good first issue This a good first issue for a community newcomer. label Jul 11, 2018
@owocki
Copy link
Contributor

owocki commented Aug 17, 2018

bounty-ing this now. i will pay 30 DAI per accepted avatar item, up to 4 per person and 10 total. please allow 1-3 iterations on your design from first submission

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented Aug 18, 2018

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 11 months, 3 weeks from now.
Please review their action plans below:

  1. writeprovidence has started work.

    i will be working on this issue

Learn more on the Gitcoin Issue Details page.

  1. vikaskyadav has started work.

    have already submitted one in WOC: Added new avatar asset for clothing #2028

Learn more on the Gitcoin Issue Details page.

  1. JosephDunivan has started work.

    Download the repo. Study current svgs for line weight, style, and color.
    Review requests for avatar changes and features from users.
    Select change requests to work on.
    Utilize Adobe Illustrator to create svgs.
    Upload svgs as described and submit for approval by your team.

Learn more on the Gitcoin Issue Details page.

  1. ajayns has started work.

    • Clone the repo and read up on the issue guides
  • Go through the existing art and design specs followed
  • Design new artwork and submit PR as per specs

Learn more on the Gitcoin Issue Details page.

  1. saricden has started work.

    I have an idea or two for avatars and would like to give this a shot.

Learn more on the Gitcoin Issue Details page.

  1. devGenie has started work.

    I have idea for some avatars that I would love to see being used.

Learn more on the Gitcoin Issue Details page.

@ajayns
Copy link
Contributor

ajayns commented Aug 20, 2018

Hey! I've been working on this for a bit now, I've studied the existing art for standards and guides followed, used the same specs and designed a couple of assets. But due to some docker build errors, I'm unable to run the repo locally and so I won't be able to post the screenshots of the avatar builder. In this situation, can I open a PR and can you guys check it out and judge instead?
Following the specs, I believe there shouldn't be any issues at all in the avatar builder. @owocki

@owocki
Copy link
Contributor

owocki commented Aug 20, 2018

mind opening up an issue for the docker errors youre seeing? cc @mbeacom

sure go ahead and submit a PR for the avatars as you expect them. this is our first time doing this so i'm unsure if it'll work or not though..

@ajayns
Copy link
Contributor

ajayns commented Aug 21, 2018

@owocki Sure! I'll also try figuring out what went wrong meanwhile.

@ajayns
Copy link
Contributor

ajayns commented Aug 21, 2018

Shirt-Sweater clothing asset (PR: #2047 )
A couple of people asked for more female themed clothing/assets in #1550
This is aimed to be unisex and fit both the genders easily. cc/ @Luminessa @reinaH

screenshot from 2018-08-21 13-57-05

@saricden
Copy link
Contributor

(PR: #2099)
Some concerned looking eyes (male & female versions):

6 svg
5 svg

@owocki
Copy link
Contributor

owocki commented Aug 27, 2018

@mbeacom @thelostone-mc i still cannot get the avatar builder to register new assets in any of these PRs.

@thelostone-mc
Copy link
Member

thelostone-mc commented Aug 29, 2018

@owocki Good for payout:

Shirt-Sweater clothing asset (PR: #2047 ) by @ajayns
Eyes male & female versions (PR #2099 ) by @saricden

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled


The funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

@owocki
Copy link
Contributor

owocki commented Aug 29, 2018

MetaMask/metamask-extension#5161

having some upstream issues with metamask... will payout after that

@JosephDunivan
Copy link

This issue is closed for now? Were there here issues on the implementation?

@thelostone-mc
Copy link
Member

thelostone-mc commented Aug 31, 2018

@JosephDunivan nope it's still open ^__^
Just follow the instructions and once your PR gets merged -> we'll tip you

Beards / Clothing / Features / anything you think which should be there

@owocki
Copy link
Contributor

owocki commented Sep 13, 2018

sorry for the slow response.. paying out now

@gitcoinbot
Copy link
Member

⚡️ A tip worth 30.00000 DAI (30.0 USD @ $1.0/DAI) has been granted to @ajayns for this issue from @owocki. ⚡️

The sender had the following public comments:

thanks!

Nice work @ajayns! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinbot
Copy link
Member

⚡️ A tip worth 30.00000 DAI (30.0 USD @ $1.0/DAI) has been granted to @saricden for this issue from @owocki. ⚡️

The sender had the following public comments:

thanks!

Nice work @saricden! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@thelostone-mc
Copy link
Member

@owocki we are good to payout @marnibrewster for #2262

@gitcoinbot
Copy link
Member

⚡️ A tip worth 30.00000 DAI (30.0 USD @ $1.0/DAI) has been granted to @marnibrewster for this issue from @owocki. ⚡️

Nice work @marnibrewster! Your tip has automatically been deposited in the ETH address we have on file.

@owocki
Copy link
Contributor

owocki commented Oct 3, 2018

anyone else wanna contribute a few more :)

@owocki owocki closed this as completed Oct 3, 2018
@ajayns
Copy link
Contributor

ajayns commented Oct 3, 2018

Is this closed now? I've had a couple ideas but didn't exactly get the time to work on them :/

@owocki
Copy link
Contributor

owocki commented Oct 3, 2018

@ajayns i'm still happy to pay them out. just closing the issue here and opening a new one at #2333 for cleanliness (note the updated pricing though! we are prioritizing clothing)

mbeacom pushed a commit that referenced this issue Oct 10, 2018
* Fix #1976 - Adjust gitcoin bot get_notifications to use pygh

* - Captured prevention of advanced payout form submission when recipient githu username is empty

Fixes: #2010

* better handling of delete requests for accounts

* Adjust makefile entry for collectstatic

* Adjust travis gh-pages deployment to only run following the lint-test stage

* Adds all activities

* Resolve #2234 - Remove error prone ja i18n and update all untranslated str for django and djangojs

* Fixes the tab module

* Profile activity_type

* Resolve autotranslate errors and compile messages

* Adds all activities with different category

* Adds tips in the activities

* Removes current categories

* html: updated text on banner contributor page

* feedback : added review

- added media queries
- adds translations + fixed spacing

* Fix #2246 - Switch org param to query icontains vs contains

* Fix #2246 - Switch org_bounties query to icontains vs contains to resolve bounty counts on org page

* css: removing multiple font-family declarations (#2192)

* css: removing multiple font-family declarations

* pydocmd: added styleguide

* Wipes out font-family from random css

* sync_geth across entire stdbounties id set 3x a week

* fix for #2248 (comment)

* Hack for:

In [4]: for tip in Tip.objects.filter(from_name='False'):
   ...:     print(tip.pk, tip.from_name)
   ...:
311 False
312 False
313 False
318 False
319 False
323 False
338 False
339 False
350 False
351 False
383 False
390 False
391 False
316 False
448 False
449 False
461 False
462 False
508 False

* fix for case sensitivitty

* Fix #2258 - Allow hidden users to view own profile from /profile/handle vs only /profile/

* Add current_profile check before accessing handle in profile_helper

* Add VSCode remote debugging handling and documentation

* Fix eslint on receive.js - travis

* Add emphasis to envvar addition before down/up of compose services for vscode debugger

* Adjust vscode launch.json snippet for default GC setup in docs

* Stopgap fix for premailer not honoring django static or templating vars for asset paths

* Adjust premailer to use base_url

* Keyword in title of Issue Explorer

* Update roundup email for 21SEP2018 (#2264)

* Update roundup email for 21SEP2018

* copy updates

* fix box position bug in select2

* Pin markdown package to resolve DRF markdown.version issue

* Fix #2232 - Adjust ENS hash txns to allow blank, switch to default empty str, and catch if empty (#2233)

* Adds fund branding organisation information with a bounty (#2039)

* Adds fund branding organisation information with a bounty

* makes stickler happy

* Related to Kevin's comment

* Makes changes in the model file

* Update migration file

* Modifies migrations to prevent conflict

* Increase Funding Limit Request Form (#2209)

* Increase Funding Limit Request Form

Fixes #2199

* Increase Funding Limit Request Form: lint

* Increase Funding Limit Request Form: lint

* Adjust dashboard migrations for conflicts

* not every contract has 18 token decimals

* updates documentation (#2270)

* gas price wei issue

* Adds Activity type and date

* Makes the issue title a required field in new funding

* Temporarily removes advanced payout as an option

* Update roundup email for 28SEP2018 (#2298)

* Adjust GH get_gh_notification handling

* Adjust notification count handling in get_notifications

* Adjust issue_details to use profile access token

* Fix #2299 - Update path to gitcoinbot readme...

* Adjust document refs for user to currentProfile and pass token to issue dets endpoint

* Fix #2305 - Resolve get_amount 404 on new bounty page (#2306)

* avatar: added space cadet clothing

Fixes : #1663

* WIP: Make It Clear Issue Has Been Crowdfunded V2

Fixes #2164

* svgo coin.svg

* crowdfunding: some ui updates.

Also revamped the additional_funding_summary bounty-property

* crowdfunding: small adjustments

* crowdfunding: fix-isort

* crowdfunding: final bits

* crowdfund: stylefix again

* crowdfund: lint

* crowdfunding: style fixes

* crowdfunding: responsive fix

* crowdfunding: decimal places 2 -> 3

* crowdfunding: fix accordion rotation

* crowdfunding: another round of improvements

* crowdfunding: ditto

* crowdfunding: hiring logo and layout

* crowdfunding: hiring logo

* bounty: hide start + submit work for funder (#2315)

Fixes: #2308

* Fix travis

* crowdfunding: normalizeAmount - decimals for tokens = 3 and dollar = 2

* Adjust loggers for gitcoin bot

* Adjust loggers for gitcoin bot

* Resolve no profile attr errors

* Add GH ratelimit healthcheck, job, cmd and additional Infura specific healthcheck (#2318)

* Add GH ratelimiting cmd/job/hc and infura pinned hc

* Remove moved healthcheck imports

* Adjust pydocmd config with new healthchecks path

* #2320

* make fix

* fix overflowing text on toolbox cards

* Fix #2329 - Adjust email template URL references and fix bad ref

* fix ios text (#2326)

* str object has no method get

* fixed parsing color from path containing domain name in avatar builder (#2321)

Fixes: #2150

* Catch on AttributeError and log sync_github errors to sentry

* lead engineer

* fix for https://sentry.gitcoin.co/gitcoin/gitcoin-prod-backend/issues/1153/?referrer=slack

* take users word for it if no gitcoin profile

* search github

* code review

* Adjust Travis config to handle GeoIP dbs (#2338)

* Add GeoIP deps to Travis env

* Derp - sudp apt-get commands

* Darn sudos

* Add search methods

* Hook up search method to user_search

* Adjust lookup to pass current token

* Add current_profile and adjust obj ref

* Timborden/location leaderboards (#2268)

* adds leaderboard by city/country/continent

* is_user_based

* code review

* test fix

* is_user_based

* is user based

* Update leaderboard tests and profile login geoIP lookup

* Resolve linting errors

* Resolve bug

* More linting fixes

* Code review changes

* Code review fixes

* Fix #2342 - Upgrade to Django 2.1.2

* mutates jobs a little bit

* Fix tooltip of start and stop work links

* Display tip received time only if it exists

* re-enables org profiles (#2343)

* Fix assemble_leaderboard

* Adds tooltip on top of user input field in Advanced payout and Basic payout

* Migrate image converter to pyvips (#2346)

* Migrate image converter to pyvips

* Remove old methods

* Adjust docstring for convert_img

* Add libvips to travis deps

* Remove unused wand import - derp

* cancel rate

* - added font class to body tag

Fixes: #2280

* refactored custom tooltip

* WIP: Feature/increase dashboard tests coverage (#858)

* dashboard: Tests cleanup.

* fixed timezone warnings
* added @staticmethod decorators where needed
* introduced consistent test naming scheme, all classes deriving from TestCase end with Test
* PEP8 line too long warnings fixed by splitting to multiline strings
* added __init__.py to let pytest find all tests when running `docker-compose exec web pytest app/dashboard/tests/*`

Refs: #607

* test_dashboard_models: Add test_exclude_bounty_by_status.

Verify that bounties can be excluded by status.

Refs: #607

* test_dashboard_models: Add test_relative_bounty_url_with_malformed_issue_number test.

The test verifies relative bounty url when malformed issue number is provided.

Refs: #607

* test_dashboard_models: Add test_get_natural_value_if_bad_token_address_provided test.

Natural value should be zero when bad token address is provided.

Issue: #607

* test_dashboard_models: Add bounty submit after expiration date tests.

Add tests:

* test_can_submit_legacy_bounty_after_expiration_date
* test_cannot_submit_standard_bounty_after_expiration_date
* test_can_submit_standard_bounty_after_expiration_date_if_deadline_extended

Refs: #607

* test_dashboard_models: Add test_title_or_desc test.

Test test_title_or_desc bounty property. Verify it returns bounty title if defined.

Refs: #607

* test_dashboard_models: title_or_desc shall return GitHub URL if no title.

Refs: #607

* test_dashboard_models: test github_issue_number.

Refs: #607

* test_dashboard_models: test github_org_name.

Refs: #607

* test_dashboard_models: test github_repo_name.

Refs: #607

* test_dashboard_models: test bounty status.

Refs: #607

* test_dashboard_embed: Add embed tests.

* test_wrap_text
* test_summarize_bounties
* test_stat
* test_embed

Issue: #607

* test_dashboard_embed: Add bounty to embed test.

Refs: #607

* test_dashboard_embed: Add avatar test.

Refs: #607

* test_dashboard_embed: Travis vs rate limiting.

GitHub API is restricted https://developer.github.com/v3/#rate-limiting
Test will also pass in that scenario. Other than that later we can mock the response.

Refs: #607

* test_notifications: Test craiglist post.

Refs: #607

* test_dashboard_utils: Add get_bounty and bounty contract tests.

* test_get_bounty
* test_get_bounty_contract

Refs: #607

* test_dashboard_utils: add get_bounty_id tests.

* test_get_bounty_id_from_db
* test_get_bounty_id_from_web3

Refs: #607

* Update test_dashboard_embed.py

* Line length

* Remove stat

* Update test_dashboard_models.py

* Remove avatar view test and fix indentation throughout new tests

* Resolve travis failures

* Remove some tests we shouldn't be performing

* Remove craigslist test and unused imports

* Bounty Requests: Move to django forms (#2096)

* Bounty Requests: Move to django forms

* Bounty Request: Fix form label binding

* Bounty Request: Fix last commit

* Disable leaderboards by location on live

* Update roundup email for 5OCT2018 (#2360)

* Update roundup email for 5OCT2018

* Review updates @owocki

* Adjust ES subscriber creation for odd doesnotexist bug

* payout: added autocomplete (#2296)

* added autocomplete

* fix user search

* fix lint

* prettified autocomplete

* stickler: fixes

* autocomplete : fixes

* enable advanced payout

* updated button styling

* Added title and meta tags (#2231)

* Added meta and canonical tags

* Added funding detail tags

* if -> elif and dropped unused assignments

Added translation blocks

* save recent searches in tabs above search bar -- like http://www.hipmunk.com/ does (#1447)

* save search recents

* linting

* removes save search button

* copy

* search history: css udpate

* fix: eslint errors

* do not save searches that are already ssaved

* deletes

* linting

* Fix eslint

* Remove title...

* remove title from about

* a new hairstyle, a tri-pony tail

* Update utils.py

fixed line that was 100+ chars

* Update utils.py

deleted whitespace

* - remove previous change
- add `g-font-muli` to `shared/nav.html`

* avatar: fixed pony tail

* Created new accessory cateogory Masks and created a Jack-o-Lantern Mask

* avatar: fix masks accessories

* lint fixes

* Added tooltip hover on tips page

* tip : autocomplete shows payout address (#2372)

* tip : autocomplete shows payout address

* remove repeating code

* results page should not destroy my CPU when it first loads... onnly load mesh data if/when needed

* adds mesh network gif

* number transactions

* pie chart

* some more fixes for results page

* bug: advanced payout

fixes: #2380

* lint fixes

* added feedback comments

* Adding live exemplars with proper formatting.

* ability to post leaderboard to slack

* updated leaderboard

* templates

* ethereum blockchain messaging removal

* fixes up the quarterly stats emails so they can be send

* npm audit

* npm audit

* npm update

* a few small fixes

*  a few small stat email fixes

* css

* still trying to fix the css

* one last time

* lorem ipsum somehow made it in

* landing: contributor page (#2405)

Fixes: https://github.com/gitcoinco/Marketing/issues/11

* top 3 thing

* fixes increase payout #2407

* hott new unfurl image for /results

* add a custom ERC20 token

* grants/index: refactor

* grants/new : refactor + update

- enable adding team-members in form
- remove duplicate file new_grant.js
- custom css + lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This a good first issue for a community newcomer.
Projects
None yet
Development

No branches or pull requests

8 participants