Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Frontend - "Thank you for supporting 'grant x' email #2285

Closed
captnseagraves opened this issue Sep 27, 2018 · 5 comments

Comments

Projects
4 participants
@captnseagraves
Copy link
Contributor

commented Sep 27, 2018

User Story

As a Grant Supporter, I want to receive an email when I begin funding a grant so that I know my transaction went through and where to find more information.

Why Is this Needed

The "Thank you for supporting "grant X" email is needed to that users can be sure that their subscription transaction went through, they can confirm the amount they're are giving and on what time interval, and so they know where to find information about the grant and how they can cancel their recurring support.

Description

Type: Feature

Definition of Done

  • Email uses the template.html file found at gitcoinco/web/app/retail/emails

  • Implement the designs found at #2082
    -assets can be found at:
    Gitcoin Email_Grants.sketch.zip

  • html file should be stored at gitcoinco/web/app/retail/emails/grants on the web/grants branch

Additional Information

Please submit work as a PR to web/grants branch

To be reviewed with @PixelantDesign @owocki @captnseagraves

Examples of previous email implementation work can be found here: gitcoinco/web/app/retail/emails

More information about the Dev Grants project can be found here: #1469

Please allow the core team a few rounds of revisions.

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.175 ETH (40.02 USD @ $228.68/ETH) attached to it as part of the Gitcoin fund__.__

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 5 months ago.
Please review their action plans below:

1) anish-agnihotri has been approved to start work.

Hey there!

I'd love to take a stab at this since it's right up my alley. I spoke to @pixelant and @captnseagraves about it yesterday, and I'd be glad to help out.

Essentially, I'd make the responsive HTML templates that would be injected in the emails and integrate the dynamic content from a views.py file (to populate the email).

Thanks, look forward to getting started.

Learn more on the Gitcoin Issue Details page.

@captnseagraves captnseagraves moved this from To do to In progress in Grants Sep 28, 2018

@Anish-Agnihotri

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2018

This page has been completed here. I've temporarily staged the files in another repository till I can make one PR containing the complete changes for multiple emails.

It follows all the requirements, and is 100% responsive. Here is an image of the live HTML:

Image

And, here is an image of the same html on a mobile display (since floating the robot does not work):

Responsive-Image

All that needs to be done, is html file added and the image that is referenced (heart-robot.png) to be added to the assets folder.

As always, let me know if there are any questions/concerns.

@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Oct 1, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.175 ETH (40.25 USD @ $230.02/ETH) has been submitted by:

  1. @Anish-Agnihotri

@captnseagraves please take a look at the submitted work:


@gitcoinbot

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.175 ETH (39.64 USD @ $226.52/ETH) attached to this issue has been approved & issued to @Anish-Agnihotri.

@captnseagraves captnseagraves moved this from In progress to Reviewer approved in Grants Oct 2, 2018

Grants automation moved this from Reviewer approved to Done Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.