New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code - /pitch pages #506

Closed
owocki opened this Issue Feb 27, 2018 · 48 comments

Comments

Projects
None yet
10 participants
@owocki
Copy link
Member

owocki commented Feb 27, 2018

Why

Because there's good ideas out there, and the community needs to know about them.

Because there's bad ideas out there, and the community needs to help the pitcher evolve them.

What

First page

Page that lives at ideas/new. Page has a web form

  • Email
  • Name
  • Github username
  • Summarize your idea (short text input)
  • Tell us more (long markdown input)
  • What are you looking for? radio input (select all that apply)
    ** capital
    ** builders
    ** designers
    ** customers
  • What are do you have already? radio input (select all that apply)
    ** capital
    ** builders
    ** designers
    ** customers

When it's submitted,

  • an email goes to settings.CONTACT_EMAIL
  • the data is stored in the DB as a new object Pitch
  • slackbot posts to community-general on gitcoin slack with the title of the idea and a link to it

Second Page

This page lives at ideas/title-url-encoded and is the 'view' page for the idea. It will display the same information as the form, and it will also give the end user the ability to upvote / comment on the idea. one upvote per ip address.

Third Page

This page is the index page of all of the ideas, and it lives at `ideas/

Designs

#198

gitcoin-ideas.zip

36632889-41740d76-195a-11e8-9041-9cc5c80abd65
36632883-3255e5f8-195a-11e8-8300-b66427fd2d09
36632886-36a49014-195a-11e8-857c-1d05c7a69063

Bounty

  • Code the frontend (HTML/CSS/JS) for the above three pages (must support tablet + mobile + desktop views)
  • Code the backend (DB models) for the above three pages too.
  • PR back to the web repo.
@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented Feb 27, 2018

This issue now has a funding of 0.22 ETH (193.79 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $8583.94 more Funded OSS Work Available at: https://gitcoin.co/explorer
@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Feb 27, 2018

This could be very interesting... I would like to throw my hat in the ring for working on this tentatively 👌

@owocki what is your timeframe when you would like to have this done by?

@owocki

This comment has been minimized.

Copy link
Member

owocki commented Feb 27, 2018

@mkosowsk i just put '1 month' as the expiration for the bounty... so ideally we'd be aiming for a merge into master within the next 3 weeks. i think that having a bounty hunter who is commited to seeing it across the finish line is more important than someone who is gonna start RIGHT NOW

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Feb 27, 2018

@owocki I will see this through, I bet @vs77bb's life on it 👍 👍 👍

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Feb 27, 2018

Will post a plan of attack by EOD Saturday, very excited to take this one on!

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 2, 2018

@PixelantDesign I am very excited to start work on this ticket by tonight 👍

Please let me know if there's some additional direction you'd like to provide. Thanks!

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

PixelantDesign commented Mar 2, 2018

hey @mkosowsk can you sync with @KennethAshley on the form styles he has been implementing?

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 2, 2018

Will do! 👍

@KennethAshley

This comment has been minimized.

Copy link
Contributor

KennethAshley commented Mar 3, 2018

Yea ive been working on the forms. let me know what you need.

@PixelantDesign these designs are bomb. Would of loved to be the one working on this ahaha.

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

PixelantDesign commented Mar 3, 2018

@KennethAshley I actually didn't design these! Seth did!

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 3, 2018

I've blocked out a lot of my weekend to work on this, so hope to deliver on these great designs!

@KennethAshley does #514 have the latest and greatest on forms for Gitcoin?

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 3, 2018

@KennethAshley I am forking from your repo to do work on this guy for forms. As I will be building extensively off your work, it's only right I send over part of the bounty if/when my PR is accepted.

Does .1 ETH sound like a fair amount to you considering this bounty is .22 ETH? Thanks! 👍

@KennethAshley

This comment has been minimized.

Copy link
Contributor

KennethAshley commented Mar 3, 2018

@mkosowsk Dude yea! Whatever you want to send over! Thanks!

@KennethAshley

This comment has been minimized.

Copy link
Contributor

KennethAshley commented Mar 3, 2018

@mkosowsk also yes, #514 has the latest and greatest!

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 3, 2018

@KennethAshley I walked through your commits and learned a thing or two... including status code 204 which I had never used before!

Just sent over that .1 ETH because talk is cheap 😂 thanks for your help! 👍🏻

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 4, 2018

First pass on the idea-modal.png design!

0 0 0 0_8000_ideas_new

This image is from a 1336x768 resolution, will work on making it responsive for tablet and mobile at a later time 👍🏻

@sethmcleod and @PixelantDesign, here are some thoughts I had as I was building this out.

  1. My first thought was should submitting a project idea be a modal or not... I opted for not using a modal as I was using a lot of inspiration from the submit_bounty.html from @KennethAshley's #514

I think it would be more internally consistent to not use a modal here as well, especially considering that it doesn't seem to me that Gitcoin is using modals much elsewhere.

  1. In that same vein, I opted to use one field for "Full Name" as opposed to splitting it into two fields for "First name" and "Last name" also per submit_bounty.html from #514

I personally am more of a fan of using "Full name" instead of splitting it as "First name" and "Last name" can be a bit confusing to the international crowd... sometimes you see these fields written out as "First/Given name" and "Last/Family name" but then at that point I think you're better off using the cleaner "Full name" and being done with it

  1. Which fields are required for this form? All of them? 🤔

  2. In the original design, radio buttons are used for the "What are you looking for?" and "What do you have already?" fields but I think checkboxes are more suited for these options. Checkboxes allow easy selection/deselection and I feel are better suited when selecting none/one/many options. Radio buttons are a better fit for when selecting one option, like how we do in Explorer for Status of "Open", "Work Started", "Work Submitted", etc. I'm happy to discuss this further and am definitely open to feedback 👍🏻

  3. Last but not least, I opted for a button styling for the "Submit" also from submit_bounty.html from #514 which is a blue block instead of a red one with rounded corners. I'm fine with either but think it would be best to standardize 👍🏻

Once these are squared away, here is my plan of attack:

  1. Do major damage first on the idea-list and then the idea-view front-end
  2. Code the backend (DB models) for the three pages (seems like these are relatively straightforward, I anticipate this to be painless... famous last words? 😂)
  3. Make the three pages responsive
  4. Open PR :)
    Been a lot of fun working on this!
@owocki

This comment has been minimized.

Copy link
Member

owocki commented Mar 6, 2018

so excited for this to get into PR stage :)

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 6, 2018

@owocki great! Will have another update by end of this Sunday (3/11) where I will have some major damage done.

I will have PR out before the following Sunday (3/18) come hell or high water 💪🏻would like to have PR out before the 18th but been getting slammed at work 😤

@sethmcleod

This comment has been minimized.

Copy link
Contributor

sethmcleod commented Mar 6, 2018

This is looking great @mkosowsk! So much fun to see these designs come to life :)

To answer some of your comments:

  1. I agree with this. Perhaps we can do some refactoring later and utilize modals throughout the app.

  2. This makes sense. I had those split up because sometimes it's nice to have a reference for the first name, for example: Hi Seth, welcome back to Gitcoin! just doesn't feel the same level of personality if my last name was included.

  3. As far as I know all fields are required.

  4. I completely overlooked that. You're right, we should have used checkboxes there instead of radios!

  5. Looks good to me! Perhaps we can update this once we finish defining UI guidelines and consistent form/button styles cc @PixelantDesign

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 7, 2018

@sethmcleod thanks for the feedback and also for providing the excellent designs, really a pleasure to work with! 👍

To point #1, I'm not married to having Full Name vs. First Name and Last Name but if we do decided to keep Full Name I think we could split the full name on the first space to have a bit of personality.

So 'Mitch Kosowski' would become 'Hi Mitch, welcome back to Gitcoin!'

Names like 'Anne Marie Smith' don't work as good tho -> 'Hi Anne, welcome back to Gitcoin!' doesn't work if she's used to be calling Anne Marie...

Anywhoo, I think the most important thing is to be consistent across the platform so as #514 is merged into default now I will roll with Full Name for the time being. Happy to discuss further at a later date like when this PR's 👍 thanks!

@vs77bb

This comment has been minimized.

Copy link
Contributor

vs77bb commented Mar 8, 2018

@mkosowsk 😍🙂

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 11, 2018

@PixelantDesign, @sethmcleod, @owocki, et al.,

The idea-view.png view uses Disqus for commenting which I am on board with but wanted to confirm that jived with the vision for Gitcoin 👍

If we use Disqus, looks like there's an npm package at https://github.com/rcurrier666/node-disqus but it seems to more popular route is just using a Universal Embed Code via https://help.disqus.com/customer/portal/articles/472097-universal-embed-code

I haven't used Disqus before but it looks fairly intuitive... definitely open to feedback on the approach :)

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 12, 2018

Quick update, was working on list view over the weekend but don't quite have this at a ready state to show off with a screen shot. I am following the design but also using a bit of inspiration from the Explorer page 👍

I am taking Friday off to do some errands but also to take this to a PR (or at least WIP PR) :)

@thelostone-mc

This comment has been minimized.

Copy link
Member

thelostone-mc commented Mar 12, 2018

@mkosowsk @PixelantDesign Are we sticking to disqus ? It kinda looks out of place
( I'm talking on long run )

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 12, 2018

@thelostone-mc I think Disqus looks somewhat out of place but I'm not sure of a better alternative 🤔

@thelostone-mc

This comment has been minimized.

Copy link
Member

thelostone-mc commented Mar 12, 2018

I've heard decent things about https://posativ.org/isso/
It's lightweight and got a shitty UI -> cause they expect you to customize it for your own site (that's exactly how it was pitched to me :P
( let's stick to Disqus to avoid any confusion, but yeah just wanted to check )

@johan718

This comment has been minimized.

Copy link

johan718 commented Mar 12, 2018

Keep up the good work @mkosowsk!

@owocki

This comment has been minimized.

Copy link
Member

owocki commented Mar 12, 2018

thanks for the update @mkosowsk

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 18, 2018

@thelostone-mc Sure, I always appreciate your help! 👍🏻👍🏻👍🏻 I will have a WIP PR open within the next 16 hours... want to spend a bit more time on it today :)

Some things I'd like to cover in that time in order of priority:

  1. Disqus integration for the ideas/new page and possibly for the ideas/list page... I did the front-end for ideas/list without Disqus and it looks like that may have been a mistake! Looks like Disqus could have handled a lot there.
  2. Yanking out the extensive and hideous inline styling I've done for this and dropping it into ideas.css in app/assets/v2/css. Possibly making a folder to hold this 🤔I was waiting a bit on the discussion for SCSS compilation to see where this styling should but it looks like this solution is appropriate for now
  3. Code the models for each of the 3 pages

My goal for today is to accomplish items 0-2, the following is future work:

  1. Make the views responsive for mobile/tablet. Hello Bootstrap!
  2. Have an email go to settings.CONTACT_EMAIL
  3. Have Slackbot post to community-general on Gitcoin slack with the title of the idea and a link to it

I'd have liked to have a lot more done at this time but I've been a bit time-constrained with personal things and work as well as building out fresh views taking a lot more time than I expected... I'm used to tweaking established designs and didn't budget enough time for starting greenfield!

I am editing my previous comment now to explain the rationale for some decisions and then will start cracking 😀

@thelostone-mc

This comment has been minimized.

Copy link
Member

thelostone-mc commented Mar 18, 2018

Haha looks like you've got it all planned out ! Sounds good to me ^_^

@owocki

This comment has been minimized.

Copy link
Member

owocki commented Mar 19, 2018

excited for the PR -- looks like this is really coming together

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 19, 2018

@owocki WIP PR is here if you've got some cycles :D

#647

@owocki

This comment has been minimized.

Copy link
Member

owocki commented Mar 19, 2018

commenting on PR now

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 23, 2018

Quick update, will address WIP PR feedback (thanks @owocki and @thelostone-mc 👍 ) this weekend and open the legit PR by end-of-day Sunday. Thanks!

@mkosowsk

This comment has been minimized.

Copy link

mkosowsk commented Mar 26, 2018

@owocki and @thelostone-mc et al, thanks for your guidance but I'm stopping work on this issue. Unfortunately my work has super ramped up recently and I just don't have the dev cycles to see this ticket through to fruition in the coming weeks. In hindsight I should have picked up something easier to digest for my first ticket on the Gitcoin project! My apologies on the bait-and-switch :(

To whomever picks this up, feel free to use any or all parts of #647 as a base if need be. Good luck!

@kziemianek

This comment has been minimized.

Copy link
Contributor

kziemianek commented Mar 27, 2018

I can take it

@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented Mar 29, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

  1. @kziemianek

has committed to working on this project to be completed 1 month ago.

kziemianek added a commit to kziemianek/web that referenced this issue Mar 30, 2018

@kziemianek kziemianek referenced this issue Mar 30, 2018

Closed

pitch pages #753

3 of 3 tasks complete

kziemianek added a commit to kziemianek/web that referenced this issue Mar 31, 2018

@kziemianek

This comment has been minimized.

Copy link
Contributor

kziemianek commented Mar 31, 2018

Does the counter next to heart icon in top right corner reflect recommends count in disqus thread?

@owocki

This comment has been minimized.

Copy link
Member

owocki commented Apr 2, 2018

Does the counter next to heart icon in top right corner reflect recommends count in disqus thread?

yes!

kziemianek added a commit to kziemianek/web that referenced this issue Apr 4, 2018

kziemianek added a commit to kziemianek/web that referenced this issue Apr 5, 2018

kziemianek added a commit to kziemianek/web that referenced this issue Apr 17, 2018

@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented Apr 22, 2018

@kziemianek are you still working on this issue?

kziemianek added a commit to kziemianek/web that referenced this issue Apr 23, 2018

kziemianek added a commit to kziemianek/web that referenced this issue Apr 24, 2018

@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented Apr 28, 2018

@kziemianek are you still working on this issue?

  • warning 1 (3 days)
  • warning 2 (6 days)
  • auto removal (10 days)
@thelostone-mc

This comment has been minimized.

Copy link
Member

thelostone-mc commented Apr 28, 2018

@kziemianek you mind leaving a comment here for the bot 😅

cc @mbeacom The inactivity period check -> as of now we check only if a comment has been posted by the hunter as a sign of activity right? (and not a referenced PR )

@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented May 1, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@kziemianek has been removed for inactivity and the issue has been returned to an ‘Open’ Status. Let us know if you believe this has been done in error!

  • warning (3 days)
  • auto removal (6 days)
@kziemianek

This comment has been minimized.

Copy link
Contributor

kziemianek commented May 2, 2018

@owocki sorry, i cannot submit my work as described in #883

@owocki

This comment has been minimized.

Copy link
Member

owocki commented May 2, 2018

ahh its bc the issue is expired. ill cancel the issue now and tip ya out when the PR is merged

@gitcoinbot

This comment has been minimized.

Copy link
Member

gitcoinbot commented May 2, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.22 ETH (148.67 USD @ $675.77/ETH) attached to this issue has been approved & issued.

@gitcoinco gitcoinco deleted a comment May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment