Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Gitcoin operator, we need to migrate certain Metamask calls #5462

Open
frankchen07 opened this issue Nov 6, 2019 · 0 comments

Comments

@frankchen07
Copy link
Contributor

@frankchen07 frankchen07 commented Nov 6, 2019

User Story

As a Gitcoin operator, we need to migrate certain Metamask calls.

Why Is this Needed

So Gitcoin doesn't break.

Description

Summary: https://medium.com/metamask/deprecating-synchronous-provider-methods-82f0edbc874b

Starting Monday, December 16, 2019, all MetaMask provider send() calls will behave asynchronously, just as they do under the hood. They will return Promises, which will resolve directly to RPC method results. We encourage you to take a look at EIP 1102 and EIP 1193 to learn about the new APIs available to you. The new ethereum.send will be live for all other methods in the next couple of weeks, so keep an eye out for that!

owocki: thought about it - an architecture that wont be super complex here: we can just call web3.eth.getcoinbase once in the base.js code that figures out what network ur on, and store it on document.coinbase. This prevents us form having to update code EVERYWHERE on the site.

document for migration: https://docs.google.com/document/d/1eJSV9BQSxBvW2DlmVsJvSA8cIYhBypgN24Ggj4gmTcM/edit#heading=h.5n5wzq6ucg3

Current Behavior

non-updated code

Expected Behavior

ensure that the returned results from the updated asynchronous calls don't break calls with the old codebase

Definition of Done

TBD

@frankchen07 frankchen07 added this to To do in Robot Board via automation Nov 6, 2019
@frankchen07 frankchen07 added this to November / Sprint 23 in Gitcoin Roadmap Nov 6, 2019
@frankchen07 frankchen07 added sprint 22 and removed sprint 22 labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Robot Board
  
To do
Gitcoin Roadmap
November / Sprint 23
2 participants
You can’t perform that action at this time.