Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: set limit for image in issue description #1159

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
3 participants
@thelostone-mc
Copy link
Member

commented May 14, 2018

Description
  • image is restricted in height & width
  • on click -> opens dialog with original image size

screenshot-2018-5-8 build new gitcoin landing page gitcoinco funded issue detail gitcoin

x1

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css
  • js
Fixes

@PixelantDesign was this what you had in mind ? ^_^

@codecov

This comment has been minimized.

Copy link

commented May 14, 2018

Codecov Report

Merging #1159 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   31.62%   31.59%   -0.04%     
==========================================
  Files         116      116              
  Lines        7885     7885              
  Branches     1026     1026              
==========================================
- Hits         2494     2491       -3     
- Misses       5282     5285       +3     
  Partials      109      109
Impacted Files Coverage Δ
app/app/settings.py 83.04% <0%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55465b0...0f15f2f. Read the comment docs.

@mbeacom
Copy link
Contributor

left a comment

I'll test this in a few, but overall, lgtm!

@mbeacom mbeacom requested a review from PixelantDesign May 14, 2018

@mbeacom mbeacom added needs design blocked and removed blocked labels May 14, 2018

@mbeacom
Copy link
Contributor

left a comment

This looks good... Just needs signed off by OP. @PixelantDesign ??

@mbeacom

This comment has been minimized.

Copy link
Contributor

commented May 16, 2018

Ping @PixelantDesign - Does this address your original request?

@mbeacom mbeacom merged commit 55297ed into gitcoinco:master May 17, 2018

3 of 5 checks passed

codecov/project 31.59% (-0.04%) compared to 55465b0
Details
codebeat 0 issues resolved and 1 introduced
Details
codecov/patch Coverage not affected when comparing 55465b0...0f15f2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@thelostone-mc thelostone-mc deleted the thelostone-mc:fix branch May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.