Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: fixed font name #1271

merged 1 commit into from May 25, 2018


None yet
2 participants
Copy link

commented May 25, 2018


Looks like we've been using the wrong font name (cause it to default to sans-serif) in a few places around the site
This PR just fixes those up

Pointed out : #1260 (comment)

  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
  • css

@ghost ghost assigned thelostone-mc May 25, 2018

@ghost ghost added the in progress label May 25, 2018

@thelostone-mc thelostone-mc requested review from mbeacom and SaptakS May 25, 2018


This comment has been minimized.

Copy link

commented May 25, 2018

Codecov Report

Merging #1271 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
- Coverage   31.37%   31.33%   -0.04%     
  Files         120      120              
  Lines        8320     8320              
  Branches     1083     1083              
- Hits         2610     2607       -3     
- Misses       5601     5604       +3     
  Partials      109      109
Impacted Files Coverage Δ
app/app/ 83.61% <0%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 187e521...c84bdea. Read the comment docs.

Copy link

left a comment

lgtm 🚢 :shipit:

@mbeacom mbeacom merged commit 051764b into gitcoinco:master May 25, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
stickler-ci No lint errors found.

@ghost ghost removed the needs review label May 25, 2018

@thelostone-mc thelostone-mc deleted the thelostone-mc:css branch May 26, 2018

CuriousLearner added a commit to CuriousLearner/web that referenced this pull request May 27, 2018

Merge branch 'master' of into fix-94…

* 'master' of (59 commits)
  psql command line
  fixes the perf / show more thing on the profile
  Adds SaptakS to team
  example widgets
  new tools assetes
  adds mission to the URL bar
  Fix gitcoinco#1274 - Get str before attempting replace
  blog link is optional
  Improves deletion confirmation modal button styling (gitcoinco#1272)
  funder list
  sorts contrib list
  adds profiles ive worked with
  Fix trans in mission
  email cleanup
  css: fixed font name (gitcoinco#1271)
  Mission/Values Page Redesign / Refactor (gitcoinco#1260)
  Deletion copy change via Vivek - Ref gitcoinco#1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.