Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart PR with corrected redirect #1308

Merged
merged 32 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@SaptakS
Copy link
Contributor

commented May 29, 2018

Description
Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Refs #1029

SaptakS and others added some commits Apr 30, 2018

@ghost ghost assigned SaptakS May 29, 2018

@ghost ghost added the in progress label May 29, 2018

@SaptakS SaptakS requested review from mbeacom and thelostone-mc May 29, 2018

@ghost ghost assigned mbeacom May 29, 2018

SaptakS and others added some commits May 29, 2018

@codecov

This comment has been minimized.

Copy link

commented May 29, 2018

Codecov Report

Merging #1308 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1308      +/-   ##
==========================================
+ Coverage   30.63%   30.64%   +0.01%     
==========================================
  Files         124      124              
  Lines        8784     8790       +6     
  Branches     1141     1141              
==========================================
+ Hits         2691     2694       +3     
- Misses       5985     5988       +3     
  Partials      108      108
Impacted Files Coverage Δ
app/app/urls.py 94.28% <ø> (ø) ⬆️
app/dashboard/views.py 16.73% <50%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72c139...2de1f76. Read the comment docs.

SaptakS added some commits May 29, 2018

@mbeacom

This comment has been minimized.

Copy link
Contributor

commented May 29, 2018

This is currently live on https://stage.gitcoin.co

Bugs so far:

  • Submitting a bounty fails with simply redirecting back to the funding form
  • Checkboxes use two different styles on the funding page

@mbeacom mbeacom added the wip label May 29, 2018

@mbeacom
Copy link
Contributor

left a comment

We'll want to address the bugs in my first comment before merging this.

@mbeacom mbeacom changed the title Quickstart PR with corrected redirect WIP: Quickstart PR with corrected redirect May 29, 2018

@mbeacom

This comment has been minimized.

Copy link
Contributor

commented May 29, 2018

quickstart

SaptakS and others added some commits May 29, 2018

@mbeacom
Copy link
Contributor

left a comment

lgtm

@SaptakS SaptakS changed the title WIP: Quickstart PR with corrected redirect Quickstart PR with corrected redirect May 31, 2018

@SaptakS SaptakS added in review and removed wip labels May 31, 2018

background-color: #FF6700;
}


This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc Jun 1, 2018

Member

extra line :P

}

.submit-notification a {
color: #fff;

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc Jun 1, 2018

Member

Don't hate me for this but can we uppercase this ( to keep it uniform )

This comment has been minimized.

Copy link
@thelostone-mc

thelostone-mc Jun 1, 2018

Member

or lower case everything! we'll have work either way

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

LGTM left a few minor comments

@SaptakS SaptakS force-pushed the SaptakS:feature/quickstart-screen branch from 9d1f94f to 0c25ca4 Jun 4, 2018

@thelostone-mc
Copy link
Member

left a comment

LGTM

@mbeacom

mbeacom approved these changes Jun 4, 2018

@mbeacom mbeacom merged commit 38c5781 into gitcoinco:master Jun 4, 2018

4 of 5 checks passed

codebeat 0 issues resolved and 1 introduced
Details
codecov/patch 50% of diff hit (target 30.63%)
Details
codecov/project 30.64% (+0.01%) compared to e72c139
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@ghost ghost removed the in progress label Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.