Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons in standalone avatar page #1524

Merged
merged 3 commits into from Jun 21, 2018

Conversation

SaptakS
Copy link
Contributor

@SaptakS SaptakS commented Jun 21, 2018

Description

Show the buttons properly in the standalone avatar page. Also fixed their working

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

@ghost ghost assigned SaptakS Jun 21, 2018
@ghost ghost added the in progress label Jun 21, 2018
@SaptakS SaptakS requested a review from mbeacom June 21, 2018 20:25
@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #1524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1524   +/-   ##
=======================================
  Coverage   28.27%   28.27%           
=======================================
  Files         129      129           
  Lines        9520     9520           
  Branches     1231     1231           
=======================================
  Hits         2692     2692           
  Misses       6730     6730           
  Partials       98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2335993...10a1ab3. Read the comment docs.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - on staging.

Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Spoke too soon! Pinged on slack.

@ghost ghost assigned thelostone-mc Jun 21, 2018
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@thelostone-mc
Copy link
Member

Added an additional css fix to ensure the buttons on the avatar page are aligned with the previous button

x1

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mbeacom mbeacom merged commit c30da4d into gitcoinco:master Jun 21, 2018
@ghost ghost removed the in progress label Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants