Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Avatar takes you to Profile Page #1559

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@SaptakS
Copy link
Contributor

commented Jun 27, 2018

  • Take to profile page after saving
Description

When using the standalone avatar builder outside of the onboarding flows, the save avatar button takes to the profile page.

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)
Testing
Refers/Fixes

Refs: #1523

Avatar pending fixes
- Take to profile page after saving

@ghost ghost assigned SaptakS Jun 27, 2018

@ghost ghost added the in progress label Jun 27, 2018

@SaptakS SaptakS requested review from mbeacom and thelostone-mc Jun 27, 2018

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2018

Codecov Report

Merging #1559 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1559      +/-   ##
=========================================
- Coverage   28.41%   28.4%   -0.01%     
=========================================
  Files         130     130              
  Lines        9566    9568       +2     
  Branches     1238    1239       +1     
=========================================
  Hits         2718    2718              
- Misses       6750    6752       +2     
  Partials       98      98
Impacted Files Coverage Δ
app/dashboard/views.py 14.71% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb311...544aa93. Read the comment docs.

@mbeacom mbeacom merged commit f3d5486 into gitcoinco:master Jun 27, 2018

3 of 5 checks passed

codecov/patch 0% of diff hit (target 28.41%)
Details
codecov/project 28.4% (-0.01%) compared to 3abb311
Details
codebeat no reportable quality changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.

@ghost ghost removed the in progress label Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.