Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor YGE code (done) & start on bulk payouts (done) #1666

Merged
merged 30 commits into from Jul 13, 2018

Conversation

Projects
None yet
6 participants
@owocki
Copy link
Member

commented Jul 9, 2018

Description

refactor YGE code (move to jquery, deprecate most of the rote JS, rename to 'onepager' which is more represntative of the template) and start on bulk payouts

TODOS:

  • Destroy YGE JS dependancies
  • Remove ETHos/coin redeem apps
  • Rename YGE to something that represents Gitcoin's app ( 'onepage' maybe )
  • rebuild Tips send flow
  • rebuild Tips receive flow
  • support for tokens
  • provide legacy way for ppl to redeem their legacy tips
  • Build Bulk Payouts
  • Analytics Updates (to disinclude pending tips)

TODO down the line after we are satisfied that all tips have been claimed -- delete receive_legacy.html, receive url route, and onepager/js/quarantine

Demo of Bulk Payouts

screen recording 2018-07-11 at 09 07 pm

Demo of NewTips Send

screen recording 2018-07-11 at 09 10 pm

Demo of NewTips Receive

screen recording 2018-07-11 at 09 13 pm

Checklist
  • linter status: 100% pass
  • changes don't break existing behavior
  • commit message follows commit guidelines
Affected core subsystem(s)

tips / youvegoteth

Testing
Refers/Fixes

#1422

v2 ticket #1720

@ghost ghost assigned owocki Jul 9, 2018

@ghost ghost added the in progress label Jul 9, 2018

@codecov

This comment has been minimized.

Copy link

commented Jul 9, 2018

Codecov Report

Merging #1666 into master will increase coverage by <.01%.
The diff coverage is 21.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   29.13%   29.14%   +<.01%     
==========================================
  Files         135      127       -8     
  Lines       10143     9835     -308     
  Branches     1333     1298      -35     
==========================================
- Hits         2955     2866      -89     
+ Misses       7083     6863     -220     
- Partials      105      106       +1
Impacted Files Coverage Δ
app/retail/emails.py 20.86% <ø> (ø) ⬆️
app/app/thumbnail_processors.py 0% <ø> (ø)
...p/dashboard/management/commands/activity_report.py 0% <ø> (ø) ⬆️
app/marketing/management/commands/pull_stats.py 0% <0%> (ø) ⬆️
app/marketing/stats.py 0% <0%> (ø) ⬆️
app/dashboard/abi.py 100% <100%> (ø)
app/app/settings.py 81.14% <100%> (-0.73%) ⬇️
app/app/urls.py 90% <100%> (ø) ⬆️
app/dashboard/views.py 15.09% <16.66%> (+0.68%) ⬆️
app/dashboard/admin.py 71.08% <20%> (-7.3%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 447f487...b27ab00. Read the comment docs.

@mbeacom

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

screenshot 2018-07-09 14 42 21

🎸\m/

$(document).ready(function() {

// jquery bindings
$("#advanced_toggle").click(function(){

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Strings must use singlequote. (quotes)
Missing space before opening brace. (space-before-blocks)

$('#amount').on('keyup blur change', updateEstimate);
$('#token').on('change', updateEstimate);
$('#token').on('change', promptForAuth);
$("#send").click(function(e){

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Strings must use singlequote. (quotes)
Missing space before opening brace. (space-before-blocks)

});

function advancedToggle() {
$('#advanced_toggle').css('display', 'none')

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Missing semicolon. (semi)


function advancedToggle() {
$('#advanced_toggle').css('display', 'none')
$('#advanced').css('display', 'block')

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Missing semicolon. (semi)

}

function validateEmail(email) {
var re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Unnecessary escape character: [. (no-useless-escape)

function isNumeric(n) {
return !isNaN(parseFloat(n)) && isFinite(n);
}

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

More than 2 blank lines not allowed. (no-multiple-empty-lines)

}


alert("todo");

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Strings must use singlequote. (quotes)

} else {
$('#usd_amount').html('</br>');
}
})

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Missing semicolon. (semi)

$('input, textarea, select').prop('disabled', '');
} else {
var from = web3.eth.coinbase;
var to = contract().address;

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 9, 2018

Expected blank line after variable declarations. (newline-after-var)

owocki added some commits Jul 9, 2018

@owocki owocki changed the title WIP -- refactor YGE code and start on bulk payouts refactor YGE code (done) & start on bulk payouts (WIP) Jul 10, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2018

@mbeacom @thelostone-mc @SaptakS

i've reached feature complete on the tips refactor and it's now working on rinkeby for both tokens and for ETH. mind taking a look?

the only WIP part left is the bulk payouts.. i can't do that today, but plan to turnaround code review and do it tomorrow on the next non-meeting-day.

@owocki owocki referenced this pull request Jul 10, 2018

Closed

Design Send Kudos #51

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 10, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2018

aiming to merge this this week

owocki added some commits Jul 11, 2018

@PixelantDesign

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2018

Very cool!

  • Should we denote some where that Basic Payout is paying 1 person and Advanced Payout pays multiple People? It's not elegant, but more explicit. Perhaps in parenthesis small underneath?
  • What do you think about renaming 'Refund' to 'Bounty Stake'? It technically is a refund, but I'm not sure if users really need to understand how all of that works. They just need to know this is X amount I'm starting with as I think about how to divide up this money.
  • Should we have a disclaimer somewhere above the payout button that the funder will need to pay the separate gas prices for each transaction/person? I'm not sure if this is technically possible but, it would be awesome to be able to pay one gas price for all 4 people.
  • Otherwise, mostly visual clean up which we can do when Saptak and Aditya are back.

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2018

some TODOS on my side:

  • All done page after info is submitted
  • Also- make sure to add local storage info about bounty

owocki added some commits Jul 12, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2018

Any chance we can split it off into a separate django module? 🤔

yes we can! feel free to add a ticket for it

Cookies keep popping up even after accepting (is it set in localStorage? )

i haven't changed any of this logic

. Should we create a separate PR for the tip flow changes or handle the url restructuring here?

i'm not sure what value that would bring. let me know what you think it does for us

Should we denote some where that Basic Payout is paying 1 person and Advanced Payout pays multiple People? It's not elegant, but more explicit. Perhaps in parenthesis small underneath?

Yes.. Where should this go? Right now theres already a "switch to basic payout" or "switch to advanced payout" link under the header.

What do you think about renaming 'Refund' to 'Bounty Stake'? It technically is a refund, but I'm not sure if users really need to understand how all of that works. They just need to know this is X amount I'm starting with as I think about how to divide up this money.

Sure, I will update this.

Should we have a disclaimer somewhere above the payout button that the funder will need to pay the separate gas prices for each transaction/person? I'm not sure if this is technically possible but, it would be awesome to be able to pay one gas price for all 4 people.

Itd be possible in a v2. At least, for all tip transactions we could do it. Can't do it for the 'cancel tx' though.

Otherwise, mostly visual clean up which we can do when Saptak and Aditya are back.

Great

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 12, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2018

@mbeacom any way to disable sticker-ci for this PR?

owocki added some commits Jul 12, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 13, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 13, 2018

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2018

@thelostone-mc 00d9b5e should satisfy your QA

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 13, 2018

@gitcoinco gitcoinco deleted a comment from stickler-ci Jul 13, 2018

@owocki owocki merged commit 639b0de into master Jul 13, 2018

0 of 4 checks passed

codebeat analysis in progress
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
stickler-ci Code review in progress

@ghost ghost removed the in progress label Jul 13, 2018

@stickler-ci

This comment has been minimized.

Copy link

commented Jul 13, 2018

There are 114 errors:

  • app/assets/onepager/js/quarantine/confetti.js, line 2 - Missing space before opening brace. (space-before-blocks)
  • app/assets/onepager/js/quarantine/confetti.js, line 5 - Expected indentation of 4 spaces but found 2. (indent)
    Split 'var' declarations into multiple statements. (one-var)
    Expected variable declaration to be on a new line. (one-var-declaration-per-line)
  • app/assets/onepager/js/quarantine/confetti.js, line 7 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 9 - Expected indentation of 4 spaces but found 2. (indent)
    A space is required after '['. (array-bracket-spacing)
    A space is required before ']'. (array-bracket-spacing)
  • app/assets/onepager/js/quarantine/confetti.js, line 11 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 13 - Expected indentation of 4 spaces but found 2. (indent)
    Strings must use singlequote. (quotes)
  • app/assets/onepager/js/quarantine/confetti.js, line 15 - Expected indentation of 4 spaces but found 2. (indent)
    Strings must use singlequote. (quotes)
  • app/assets/onepager/js/quarantine/confetti.js, line 17 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 19 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 21 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 22 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 23 - Expected indentation of 6 spaces but found 4. (indent)
    Return statement should not contain assignment. (no-return-assign)
  • app/assets/onepager/js/quarantine/confetti.js, line 24 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 26 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 28 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 30 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 31 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 32 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 34 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 35 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 36 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 37 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 38 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 39 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 41 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 43 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 44 - Expected indentation of 6 spaces but found 4. (indent)
    Return statement should not contain assignment. (no-return-assign)
  • app/assets/onepager/js/quarantine/confetti.js, line 45 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 47 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 48 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 49 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 50 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 51 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 53 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 54 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 55 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 56 - Expected indentation of 8 spaces but found 6. (indent)
    Strings must use singlequote. (quotes)
  • app/assets/onepager/js/quarantine/confetti.js, line 57 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 58 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 59 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 60 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 62 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 63 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 64 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 65 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 66 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 67 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 68 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 69 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 70 - Expected indentation of 8 spaces but found 6. (indent)
    Return statement should not contain assignment. (no-return-assign)
  • app/assets/onepager/js/quarantine/confetti.js, line 71 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 73 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 74 - Expected indentation of 8 spaces but found 6. (indent)
    Expected blank line after variable declarations. (newline-after-var)
  • app/assets/onepager/js/quarantine/confetti.js, line 75 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 76 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 77 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 78 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 79 - Expected indentation of 10 spaces but found 8. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 80 - Expected indentation of 10 spaces but found 8. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 81 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 82 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 83 - Expected indentation of 10 spaces but found 8. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 84 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 85 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 86 - Expected indentation of 10 spaces but found 8. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 87 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 88 - Expected indentation of 8 spaces but found 6. (indent)
    Strings must use singlequote. (quotes)
  • app/assets/onepager/js/quarantine/confetti.js, line 89 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 91 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 93 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 95 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 96 - Expected indentation of 6 spaces but found 4. (indent)
    Split 'var' declarations into multiple statements. (one-var)
    Expected blank line after variable declarations. (newline-after-var)
    Expected variable declaration to be on a new line. (one-var-declaration-per-line)
  • app/assets/onepager/js/quarantine/confetti.js, line 97 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 98 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 99 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 100 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 101 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 102 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 104 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 105 - Expected indentation of 6 spaces but found 4. (indent)
    Expected blank line after variable declarations. (newline-after-var)
    Split 'var' declarations into multiple statements. (one-var)
    Expected variable declaration to be on a new line. (one-var-declaration-per-line)
  • app/assets/onepager/js/quarantine/confetti.js, line 106 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 107 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 108 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 109 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 110 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 111 - Expected indentation of 8 spaces but found 6. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 112 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 113 - Expected indentation of 6 spaces but found 4. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 114 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 116 - Expected indentation of 4 spaces but found 2. (indent)
  • app/assets/onepager/js/quarantine/confetti.js, line 118 - Expected indentation of 2 spaces but found 0. (indent)
    Trailing spaces not allowed. (no-trailing-spaces)
  • app/assets/onepager/js/quarantine/confetti.js, line 122 - Missing space before opening brace. (space-before-blocks)
  • app/assets/onepager/js/quarantine/confetti.js, line 123 - Expected blank line after variable declarations. (newline-after-var)
    Strings must use singlequote. (quotes)
  • app/assets/onepager/js/quarantine/confetti.js, line 125 - Missing space before opening brace. (space-before-blocks)
    Unexpected empty function. (no-empty-function)
  • app/assets/onepager/js/quarantine/confetti.js, line 126 - A space is required after ','. (comma-spacing)
  • app/assets/onepager/js/quarantine/confetti.js, line 130 - Missing space before opening brace. (space-before-blocks)
  • app/assets/onepager/js/quarantine/confetti.js, line 132 - Missing space before opening brace. (space-before-blocks)
  • app/assets/v2/js/pages/bulk_payout.js, line 70 - Strings must use singlequote. (quotes)
    A space is required after ','. (comma-spacing)
  • app/assets/v2/js/pages/bulk_payout.js, line 71 - Strings must use singlequote. (quotes)
    A space is required after ','. (comma-spacing)
  • app/assets/v2/js/pages/bulk_payout.js, line 129 - Expected indentation of 8 spaces but found 10. (indent)
  • app/dashboard/abi.py, line 3 - E501 line too long (4082 > 120 characters)
  • app/dashboard/models.py, line 922 - F811 redefinition of unused 'amount_in_wei' from line 914
  • app/dashboard/models.py, line 928 - F811 redefinition of unused 'amount_in_whole_units' from line 918
  • app/dashboard/tip_views.py, line 35 - F401 'github.utils.get_auth_url' imported but unused
    F401 'github.utils.get_github_user_data' imported but unused
    F401 'github.utils.is_github_token_valid' imported but unused
  • app/dashboard/tip_views.py, line 38 - F401 'marketing.mails.admin_contact_funder' imported but unused
    F401 'marketing.mails.bounty_uninterested' imported but unused
    F401 'marketing.mails.start_work_approved' imported but unused
    F401 'marketing.mails.start_work_new_applicant' imported but unused
    F401 'marketing.mails.start_work_rejected' imported but unused
  • app/dashboard/tip_views.py, line 45 - F401 '.models.Activity' imported but unused
    F401 '.models.Bounty' imported but unused
    F401 '.models.CoinRedemption' imported but unused
    F401 '.models.CoinRedemptionRequest' imported but unused
    F401 '.models.Interest' imported but unused
    F401 '.models.ProfileSerializer' imported but unused
    F401 '.models.Subscription' imported but unused
    F401 '.models.Tool' imported but unused
    F401 '.models.ToolVote' imported but unused
    F401 '.models.UserAction' imported but unused
  • app/dashboard/tip_views.py, line 49 - F401 '.notifications.maybe_market_to_github' imported but unused
    F401 '.notifications.maybe_market_to_slack' imported but unused
    F401 '.notifications.maybe_market_to_twitter' imported but unused
    F401 '.notifications.maybe_market_to_user_discord' imported but unused
    F401 '.notifications.maybe_market_to_user_slack' imported but unused
  • app/dashboard/tip_views.py, line 53 - F811 redefinition of unused 'has_tx_mined' from line 32
    F401 '.utils.get_bounty' imported but unused
    F401 '.utils.get_bounty_id' imported but unused
    F401 '.utils.get_context' imported but unused
    F401 '.utils.record_user_action_on_interest' imported but unused
    F401 '.utils.web3_process_bounty' imported but unused
  • app/dashboard/tip_views.py, line 72 - E302 expected 2 blank lines, found 1
  • app/dashboard/tip_views.py, line 129 - E501 line too long (129 > 120 characters)
  • app/dashboard/tip_views.py, line 214 - F841 local variable 'primary_from_email' is assigned to but never used
  • app/dashboard/tip_views.py, line 215 - F841 local variable 'access_token' is assigned to but never used
  • app/dashboard/tip_views.py, line 247 - E303 too many blank lines (3)
  • app/dashboard/tip_views.py, line 296 - F841 local variable 'tip' is assigned to but never used

@thelostone-mc thelostone-mc deleted the kevin/yge_demolition_and_bulk_payout branch Jul 19, 2018

@mbeacom

This comment has been minimized.

Copy link
Contributor

commented on app/dashboard/models.py in 4029451 Jul 21, 2018

@owocki Which of these methods do we want to use here? Looks like we're redefining amount_in_wei and amount_in_whole_units - the last two?

This comment has been minimized.

Copy link
Member Author

replied Jul 23, 2018

probably amount_in_whole_units since wei is an ETH specific unit of account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.