Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor YGE code (done) & start on bulk payouts (done) #1666
refactor YGE code (move to jquery, deprecate most of the rote JS, rename to 'onepager' which is more represntative of the template) and start on bulk payouts
TODO down the line after we are satisfied that all tips have been claimed -- delete
Demo of Bulk Payouts
Demo of NewTips Send
Demo of NewTips Receive
Affected core subsystem(s)
tips / youvegoteth
v2 ticket #1720
@@ Coverage Diff @@ ## master #1666 +/- ## ========================================== + Coverage 29.13% 29.14% +<.01% ========================================== Files 135 127 -8 Lines 10143 9835 -308 Branches 1333 1298 -35 ========================================== - Hits 2955 2866 -89 + Misses 7083 6863 -220 - Partials 105 106 +1
i've reached feature complete on the tips refactor and it's now working on rinkeby for both tokens and for ETH. mind taking a look?
the only WIP part left is the bulk payouts.. i can't do that today, but plan to turnaround code review and do it tomorrow on the next non-meeting-day.
yes we can! feel free to add a ticket for it
i haven't changed any of this logic
i'm not sure what value that would bring. let me know what you think it does for us
Yes.. Where should this go? Right now theres already a "switch to basic payout" or "switch to advanced payout" link under the header.
Sure, I will update this.
Itd be possible in a v2. At least, for all tip transactions we could do it. Can't do it for the 'cancel tx' though.
Jul 13, 2018
There are 114 errors: