Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach job desc ux fixes #1787

Merged
merged 6 commits into from Jul 19, 2018

Conversation

Projects
None yet
4 participants
@owocki
Copy link
Member

commented Jul 19, 2018

  1. remembers your job desc and that you're hiring when you post a new bounty
  2. shows 'hiring' label in issue explorer. screenshot => http://bits.owocki.com/3j1A45110X1g/Screen%20Shot%202018-07-18%20at%2010.24.35%20PM.png
  3. allows your to filter by only those who are hiring . screenshot => http://bits.owocki.com/2n1U2U2k2V0C/Screen%20Shot%202018-07-18%20at%2010.25.06%20PM.png

@ghost ghost assigned owocki Jul 19, 2018

@ghost ghost added the in progress label Jul 19, 2018

@@ -17,7 +17,8 @@ var sidebar_keys = [
'idx_status',
'tech_stack',
'project_type',
'permission_type'
'permission_type',
'misc',

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Unexpected trailing comma. (comma-dangle)

@@ -80,6 +80,14 @@ $(document).ready(function() {
')'
).prop('selected', true);
}

if (localStorage['jobDescription']) {
$("#jobDescription").val(localStorage['jobDescription']);

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Strings must use singlequote. (quotes)


if (localStorage['jobDescription']) {
$("#jobDescription").val(localStorage['jobDescription']);
setTimeout(function(){

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Missing space before opening brace. (space-before-blocks)

if (localStorage['jobDescription']) {
$("#jobDescription").val(localStorage['jobDescription']);
setTimeout(function(){
$('#hiringRightNow').attr('checked', 'checked');

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Expected indentation of 6 spaces but found 8. (indent)

$("#jobDescription").val(localStorage['jobDescription']);
setTimeout(function(){
$('#hiringRightNow').attr('checked', 'checked');
open_hiring_panel(false);

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Expected indentation of 6 spaces but found 8. (indent)

setTimeout(function(){
$('#hiringRightNow').attr('checked', 'checked');
open_hiring_panel(false);
},10);

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

A space is required after ','. (comma-spacing)

@@ -140,18 +148,22 @@ $(document).ready(function() {
if ($('input[name=amount]').val().trim().length > 0) {
setUsdAmount();
}

$('#hiringRightNow').click(function() {
var open_hiring_panel = function(do_focus) {

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Expected blank line after variable declarations. (newline-after-var)

setTimeout(function() {
var hiringRightNow = $('#hiringRightNow').is(':checked');

if (hiringRightNow) {
$('#jobDescription').removeClass('hidden');
$('#jobDescription').focus();
if(do_focus){

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Expected space(s) after "if". (keyword-spacing)
Missing space before opening brace. (space-before-blocks)

} else {
$('#jobDescription').addClass('hidden');
}
}, 10);
};
$('#hiringRightNow').click(function(){

This comment has been minimized.

Copy link
@stickler-ci

stickler-ci Jul 19, 2018

Missing space before opening brace. (space-before-blocks)

@SaptakS

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2018

@owocki the hiring label seems to have an orange border on the left. Is that intentional?

@owocki owocki requested review from thelostone-mc, mbeacom and SaptakS Jul 19, 2018

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

@SaptakS lol the orange boundry is cause there is rinkeby tag behind it
Not sure how to fix this :P Wanna give it a shot ?

We could leave it there cause it would not show up on the mainnet anyways

@owocki

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2018

82ebd87 and bf9b772 fixes that

@thelostone-mc
Copy link
Member

left a comment

LGTM !

@owocki owocki merged commit 8d28ad5 into master Jul 19, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
stickler-ci No lint errors found.

@ghost ghost removed the in progress label Jul 19, 2018

@thelostone-mc

This comment has been minimized.

Copy link
Member

commented Jul 19, 2018

@owocki that is not a fix 😂
Nice jugaad though (indian term for hack)

@thelostone-mc thelostone-mc deleted the kevin/job_desc_fixes branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.